Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare support for react-native 0.68 #789

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Mar 30, 2022

Summary

react-native 0.68 just released. AsyncStorage should be compatible afaik (though I haven't done any super extensive testing).

Test Plan

n/a

@tido64 tido64 requested a review from krizzu March 30, 2022 15:14
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any breaking changes related on the release notes, so good to go

@tido64 tido64 linked an issue Mar 31, 2022 that may be closed by this pull request
5 tasks
@tido64 tido64 merged commit 6e2c941 into master Mar 31, 2022
@tido64 tido64 deleted the tido/support-0.68 branch March 31, 2022 15:28
@krizzu
Copy link
Member

krizzu commented Mar 31, 2022

🎉 This PR is included in version 1.17.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@crobinson42
Copy link

Is this expected? react-native v 0.68.2
image

@tido64
Copy link
Member Author

tido64 commented May 27, 2022

Is this expected? react-native v 0.68.2 image

Hi @crobinson42, please open a new issue here and fill out the template: https://github.com/react-native-async-storage/async-storage/issues/new?assignees=&labels=bug&template=bug_report.yml

I think it would help if you can include the content of your package.json as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERR! Could not resolve dependency
3 participants