feat: migrate from Flow to TypeScript #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bilalq
reviewed
Jan 14, 2022
- Migrated all Flow files to TypeScript - Disabled 'dot-notation' ESLint rule conflicting with TypeScript - Use more default Prettier settings - Moved ESLint and Prettier config into package.json
tido64
force-pushed
the
tido/flow-to-typescript
branch
from
baae5b3 to
a7895cd
Compare
kopax-polyconseil
approved these changes
Feb 7, 2022
|
Thanks for contributing ! This PR is awesome, I hope it will be merged soon ! |
krizzu
approved these changes
Feb 9, 2022
Comment on lines
+361
to
+364
| if (!RCTAsyncStorage.multiMerge) { | ||
| delete AsyncStorage.mergeItem; | ||
| delete AsyncStorage.multiMerge; | ||
| } |
There was a problem hiding this comment.
guess we could get rid of that, all platforms include this methods
There was a problem hiding this comment.
I'll leave it in for now. I want this change to be more or less a pure migration. We can remove it in a separate PR.
|
🎉 This PR is included in version 1.16.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
|
Why |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
CI should pass.