-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetQuads has a false Typescript definition #322
Comments
Generally speaking I would recommend using I'm also happy to review a PR to definitelyTyped updating the types. |
Also something that should probably be updated at the same time is ensuring that |
Are you referring to for example to the different implementations of RDF.NamedNode in rdf-data-factory and N3? Rdf-data-factory => this seems to be the correct implementation of the rdf-js specification
}` N3 `export class NamedNode implements RDF.NamedNode {
}` This basically means that I cannot use a quad from the factory with a N3.store without asserting types. |
I mean that export type Quad_Subject = NamedNode | BlankNode | Variable;
export type Quad_Predicate = NamedNode | Variable;
export type Quad_Object = NamedNode | Literal | BlankNode | Variable;
export type Quad_Graph = DefaultGraph | NamedNode | BlankNode | Variable; at the very least should be
to reflect the fact that the store supports rdf-star nested triples (in actual fact the implementation really supports |
Every parameter in GetQuads should accept null or undefined but in the type definition file it is required to provide a OTerm.
I could change the type definitions and create a pull request if you would point me in the right direction.
Related to #139 #298
The text was updated successfully, but these errors were encountered: