Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger need compression feature #589

Open
4 tasks
Petrarka0 opened this issue Aug 28, 2024 · 1 comment
Open
4 tasks

Logger need compression feature #589

Petrarka0 opened this issue Aug 28, 2024 · 1 comment

Comments

@Petrarka0
Copy link

Petrarka0 commented Aug 28, 2024

Is your feature request related to a problem?

logs big af
image
Need to add some compression.
Also you cannot set period and other settings of file_handler in TwitchChannelPointsMiner.logger_settings , only bool auto_clear

Proposed solution

TODO:

  1. logger.py
    • relocate default settings file_handler to LoggerSettings._init_
    • rewrite configure_loggers() so file_handler can use settings: LoggerSettings
  2. example.py (run.py)
    • Add file_handler in logger_settings
  • override? TimedRotatingFileHandler methods to add compression after log file rotate

Alternatives you've considered

No response

Additional context

No response

@Petrarka0
Copy link
Author

maybe should i split it to separate issues 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant