Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NilTimer should execute function argument in Time #228

Open
chewr opened this issue Mar 9, 2018 · 1 comment · May be fixed by #231
Open

NilTimer should execute function argument in Time #228

chewr opened this issue Mar 9, 2018 · 1 comment · May be fixed by #231

Comments

@chewr
Copy link

chewr commented Mar 9, 2018

The NilTimer implements the Timer's Time(func()) method but does so as a noop. In order to preserve behavior for callers which use this method and rely on the argument being executed, the NilTimer should execute the function that is passed to it.

https://github.com/rcrowley/go-metrics/blob/master/timer.go#L129
@chewr chewr linked a pull request Mar 23, 2018 that will close this issue
Open
@lexand
Copy link

lexand commented Mar 11, 2020

this repository is dead ? or why the fix is still not on master ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NilTimer executes given function chewr/go-metrics
2 participants
@lexand @chewr