Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of version number in registry interferes with proper winget behaviour #349

Closed
Quitch opened this issue Oct 12, 2021 · 3 comments · Fixed by #353
Closed

Lack of version number in registry interferes with proper winget behaviour #349

Quitch opened this issue Oct 12, 2021 · 3 comments · Fixed by #353
Labels
area: packaging improvement Improvement of an existing feature os: windows Windows specific

Comments

@Quitch
Copy link
Contributor

Quitch commented Oct 12, 2021 •
edited
Loading

Describe the bug
A lack of the "DisplayVersion" REG_SZ, or "Version", "VersionMajor", and "VersionMinor" REG_DWORDs within Computer\HKEY_LOCAL_MACHINE\SOFTWARE\WOW6432Node\Microsoft\Windows\CurrentVersion\Uninstall\Workrave_is1 means that Microsoft's Windows Package Manager (winget) registers the version of WorkRave as "Unknown" and will always attempt to upgrade it.

To Reproduce
Steps to reproduce the behavior:

  1. Install "App Installer" from the Microsoft Store
  2. Open a command prompt or PowerShell terminal
  3. "winget list workrave"

Expected behavior
Version column will show currently installed version of WorkRave

Screenshots
image

** Windows (please complete the following information in case you encountered the bug on Windows):

  • Windows Version: Windows 10 21H1
  • Workrave Version 1.10.48

Additional context
microsoft/winget-cli#1255 (comment)
@Quitch Quitch changed the title No version number in registry interferes with proper winget behaviour Lack of version number in registry interferes with proper winget behaviour Oct 12, 2021
@rcaelers rcaelers added area: packaging improvement Improvement of an existing feature os: windows Windows specific labels Oct 13, 2021
This was referenced Nov 1, 2021
Closed
Merged
@anaurelian
Copy link

Do you know when this fix is going to be implemented in a public release? Thank you

@rcaelers
Copy link
Owner

rcaelers commented Jan 5, 2022

I just released 1.10.49 which contains this fix.

@anaurelian
Copy link

Thank you, I've also closed the related issue in microsoft/winget-pkgs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: packaging improvement Improvement of an existing feature os: windows Windows specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Version Entry to Inno Setup
3 participants
@rcaelers @Quitch @anaurelian