Skip to content
This repository was archived by the owner on Nov 14, 2023. It is now read-only.

Commit 0ffd2b0

Browse files
aaron-steinfeldjaywalker21
authored andcommitted
fix: avoid dupe columns, clear group name from url on none (hypertrace#1269)
1 parent 75af0c4 commit 0ffd2b0

File tree

2 files changed

+25
-3
lines changed

2 files changed

+25
-3
lines changed

projects/observability/src/pages/explorer/explorer-dashboard-builder.ts

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -522,9 +522,26 @@ export class ExplorerDashboardBuilder {
522522
protected getAttributesToExcludeFromUserDisplay(context: ExplorerGeneratedDashboardContext): Set<string> {
523523
switch (context) {
524524
case ObservabilityTraceType.Api:
525-
return new Set(['protocol', 'apiName', 'statusCode', 'duration', 'startTime', 'calls']);
525+
return new Set([
526+
'protocol',
527+
'serviceName',
528+
'apiName',
529+
'statusCode',
530+
'apiTraceErrorSpanCount',
531+
'duration',
532+
'startTime',
533+
'calls'
534+
]);
526535
case SPAN_SCOPE:
527-
return new Set(['protocolName', 'displaySpanName', 'statusCode', 'duration', 'startTime']);
536+
return new Set([
537+
'protocolName',
538+
'serviceName',
539+
'displaySpanName',
540+
'statusCode',
541+
'errorCount',
542+
'duration',
543+
'startTime'
544+
]);
528545
default:
529546
return assertUnreachable(context);
530547
}

projects/observability/src/pages/explorer/explorer.component.ts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,12 @@ export class ExplorerComponent {
195195
private getGroupByQueryParams(groupBy?: GraphQlGroupBy): QueryParamObject {
196196
const key = groupBy?.keys[0];
197197
if (key === undefined) {
198-
return {};
198+
return {
199+
// Clear existing selection
200+
[ExplorerQueryParam.Group]: undefined,
201+
[ExplorerQueryParam.OtherGroup]: undefined,
202+
[ExplorerQueryParam.GroupLimit]: undefined
203+
};
199204
}
200205

201206
return {

0 commit comments

Comments
 (0)