refactor: added validation on buffer percent limits #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashish10677
previously approved these changes
Aug 30, 2024
ashish10677
requested changes
Aug 30, 2024
ashish10677
approved these changes
Sep 3, 2024
Yashk767
force-pushed
the
yash/raz-971-add-a-validation-for-buffer-percent-to-be-in-valid-range
branch
from
753de21
to
05214b6
Compare
ashish10677
approved these changes
Sep 3, 2024
rajkharvar
approved these changes
Sep 4, 2024
Yashk767
deleted the
yash/raz-971-add-a-validation-for-buffer-percent-to-be-in-valid-range
branch
Yashk767
added a commit
to Yashk767/razor-go
that referenced
this pull request
Sep 16, 2024
* refactor: calculated gas limit using formula for reveal transaction (razor-network#1231) * chore: updated deployment parameters for 5 min epoch europa contracts (razor-network#1229) * chore: updated deployement parameters for 5 min europa chain * refactor: fixed statelength and epochlength change tests * chore: updated version to v2.0.0 * refactor: updated the chain name to EUROPA in chainId info * refactor: added validation on buffer percent limits (razor-network#1228) * refactor: added validation on buffer percent limits * refactor: fixed tests * refactor: updated default value when builded from source in config script * refactor: fixed lint error * refactor: fixed vote tests * refactor: fixed getBufferPercent() tests * refactor: recorrected the comment for max buffer formula used * chore: updated config variable default and limits for 5 min epoch (razor-network#1232) * refactor: created the local cache instance only once (razor-network#1233) * refactor: replaced goroutine cleanuploop with normal cleanup function * refactor: initialised local cache only once an reused again * refactor: fixed tests * chore: update default wait time in config.sh (razor-network#1234)
Yashk767
added a commit
that referenced
this pull request
Sep 16, 2024
* refactor: calculated gas limit using formula for reveal transaction (#1231) * chore: updated deployment parameters for 5 min epoch europa contracts (#1229) * chore: updated deployement parameters for 5 min europa chain * refactor: fixed statelength and epochlength change tests * chore: updated version to v2.0.0 * refactor: updated the chain name to EUROPA in chainId info * refactor: added validation on buffer percent limits (#1228) * refactor: added validation on buffer percent limits * refactor: fixed tests * refactor: updated default value when builded from source in config script * refactor: fixed lint error * refactor: fixed vote tests * refactor: fixed getBufferPercent() tests * refactor: recorrected the comment for max buffer formula used * chore: updated config variable default and limits for 5 min epoch (#1232) * refactor: created the local cache instance only once (#1233) * refactor: replaced goroutine cleanuploop with normal cleanup function * refactor: initialised local cache only once an reused again * refactor: fixed tests * chore: update default wait time in config.sh (#1234) * chore: updated npm version and mainnet contract addresses to official contracts for 5 min epoch (#1243) * chore: updated mainnet contract addresses to official 5 min epoch contracts * chore: updated contracts version in dependencies * chore: updated node-version in workflows * refactor: update package-lock.json and reinstall dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a validation before voting process starts to check buffer percent should be within limit of default value and maximum value.
Maximum value for buffer percent is calculated using state buffer and state length.
Fixes https://linear.app/interstellar-research/issue/RAZ-971
This will fix https://linear.app/interstellar-research/issue/RAZ-965 as well as we update the default buffer percent value for shorter epoch value.