fix: conversion of hex to decimal #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashish10677
approved these changes
Nov 28, 2023
rajkharvar
approved these changes
Nov 28, 2023
SkandaBhat
pushed a commit
that referenced
this pull request
Dec 11, 2023
Yashk767
added a commit
that referenced
this pull request
Jan 15, 2024
Yashk767
added a commit
that referenced
this pull request
Jan 17, 2024
#1177) * fix: conversion of hex to decimal (#1167) * fix: conversion of hex to decimal * fix: convertToNumber tests fixed * feat: added support for job returning results in hex array (#1174) * feat: added support for jobs returning result in hex array * feat: added tests for hex array decoding and regex functions * refactor: fixed golangci-lint errors * refactor: used hash of url and body as a cache key (#1176) * refactor: used hash of url and body as cache key instead of just url * fix: replaced with new cacheKey while reading from cache * refactor: added tests for different job cases * refcator: added missing coverage test cases * refcator: fixed tests * refactor: fixted tests by replcing binance API with coinbase API * refactor: job index changed in test name * fix: conversion of hex to decimal (#1167) (#1169) (#1178) * fix: conversion of hex to decimal * fix: convertToNumber tests fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While returning in
ConvertHexToBigFloat()we converthexValueUint64tofloat64usingwhich is an invalid conversion in case of hex values in
uint64, we should instead convert usingFixes https://linear.app/interstellar-research/issue/RAZ-604
How Has This Been Tested?
Added test cases with data returned from real jobs.