Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] make clean should delete raygui.c #3288

Closed
SuperUserNameMan opened this issue Sep 4, 2023 · 2 comments · Fixed by #3296
Closed

[build] make clean should delete raygui.c #3288

SuperUserNameMan opened this issue Sep 4, 2023 · 2 comments · Fixed by #3296

Comments

@SuperUserNameMan
Copy link
Contributor

SuperUserNameMan commented Sep 4, 2023

Hello,

Compiling Raylib 4.5.0 + Raygui 3.6 on Linux :

The #include path in raygui.c is not updated if the value of RAYLIB_MODULE_RAYGUI_PATH is changed on a next compilation attempt.
And make clean does not delete raygui.c.

Same issue might happens with RAYLIB_MODULE_PHYSAC_PATH. (untested)

First attempt :
make RAYLIB_LIBTYPE=SHARED RAYLIB_MODULE_RAYGUI=TRUE

  • raygui.c is created with default path.
  • compilation might fail because expected default raygui path did not match cruel reality.

Second attempt :
make clean
make RAYLIB_LIBTYPE=SHARED RAYLIB_MODULE_RAYGUI=TRUE RAYLIB_MODULE_RAYGUI_PATH=../../raylib-3.6/src

  • compilation fails because raygui.c was neither updated nor cleaned.
@raysan5 raysan5 changed the title make clean should delete raygui.c [build] make clean should delete raygui.c Sep 4, 2023
@raysan5
Copy link
Owner

raysan5 commented Sep 5, 2023

@SuperUserNameMan Feel free to send a PR with the review.

@SuperUserNameMan
Copy link
Contributor Author

ok, done, but could not test under Windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants