Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] core_scissor_test not working properly on high DPI screen #2142

Closed
lukekras opened this issue Nov 14, 2021 · 6 comments · Fixed by #2170
Closed

[core] core_scissor_test not working properly on high DPI screen #2142

lukekras opened this issue Nov 14, 2021 · 6 comments · Fixed by #2170

Comments

@lukekras
Copy link
Contributor

lukekras commented Nov 14, 2021

  • [ x] I tested it on latest raylib version from master branch
  • [ x] I checked there is no similar issue already reported
  • [ x] My code has no errors or misuse of raylib

Issue description

I was running the core_scissor_test example program and it wasn't working on a high DPI MacBook Pro. The scissor red box was out of alignment to the mouse outline box.

Environment

macOS Big Sur Intel MacBook Pro

INFO: GL: OpenGL device information:
INFO: > Vendor: Intel Inc.
INFO: > Renderer: Intel(R) Iris(TM) Plus Graphics 650
INFO: > Version: 4.1 INTEL-16.5.2
INFO: > GLSL: 4.10

Issue Screenshot

Screen Shot 2021-11-14 at 10 22 19 pm

Code Example

I've submitted a PR #2141

@raysan5
Copy link
Owner

raysan5 commented Nov 15, 2021

Related: #1982 and #1987

@lukekras
Copy link
Contributor Author

Closed PR #2141 and created PR #2160 with refactored code.

@raysan5
Copy link
Owner

raysan5 commented Nov 23, 2021

@ArnaudValensi pushed a big commit related, maybe he can look into this issue?

@lukekras
Copy link
Contributor Author

@raysan5 @ArnaudValensi
I've checked out Fix scissor on macos #2170 and confirm that it fixes this problem. From my point of view this issue can be closed.

PR #2170 makes PR Fix scissor mode for high DPI screens (refactored) #2160 redundant.

@raysan5
Copy link
Owner

raysan5 commented Nov 25, 2021

@ArnaudValensi @lukekras thanks to you both for working on this issue and the reviews!

@lukekras
Copy link
Contributor Author

No problem @raysan5, happy to help where I can. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants