New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Add Choice For Banner Image Position #48

Closed

rayhannabi opened this issue Sep 2, 2019 · 1 comment

Assignees

Labels

Milestone

Owner

rayhannabi commented Sep 2, 2019

Banner Image should be placed in the following positions:

before the body (where the status images should go also, also see Issue [NEW] Add Header Image Based On Alert Types #46)
after the body - the current default

The setBannerImage(_:) would be changed to setBannerImage(_:position:). position would be an enum type with the following cases:

beforeBody
afterBody

The text was updated successfully, but these errors were encountered:

rayhannabi added the enhancement label

rayhannabi self-assigned this

rayhannabi added this to the Version 1.0.0 milestone

Owner Author

rayhannabi commented Jan 14, 2020

Implemented, See #87

rayhannabi closed this as completed

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment