[rllib] Log or raise error if not fully handled #58889
Merged
+11
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Towers <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error handling by logging or re-raising exceptions that were previously being ignored. This is a great change for improving the debuggability of RLlib. The changes are in the right direction. I've added a few comments with suggestions to use the logging module consistently instead of print, and to use logger.exception in a more idiomatic way.
Signed-off-by: Mark Towers <[email protected]>
ArturNiederfahrenhorst
assigned
ArturNiederfahrenhorst and unassigned
ArturNiederfahrenhorst
Contributor
ArturNiederfahrenhorst
left a comment
ArturNiederfahrenhorst
left a comment
There was a problem hiding this comment.
Nice! What do you think about putting some more information into the error that pops up when we can't solve references?
This kind of errors comes up a lot when using spot instances and we should ensure that users are not alarmed each time they discover this log message.
Signed-off-by: Mark Towers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checking RLlib, there are a couple cases where we don't fully handle exception cases.
I've checked every try except statement in RLlib and this PR updates all of them that didn't log or print the error if it wasn't handled
Related issues
Fixes #58854