Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .buildkite/_images.rayci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ steps:
CUDA_VERSION: "{{matrix.cuda}}"
IMAGE_TYPE: "ray"
ARCH_SUFFIX: ""
REQUIREMENTS_FILE: "ray_base_extra_py{{matrix.python}}.lock"
depends_on: raycudabase

- name: ray-llmbase
Expand Down
19 changes: 19 additions & 0 deletions ci/raydepsets/configs/rayimg.depsets.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -115,3 +115,22 @@ depsets:
build_arg_sets:
- py39
- py310

- name: ray_base_extra_${PYTHON_SHORT}
operation: subset
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add some comment that explains why this is a subset?

source_depset: ray_base_extra_testdeps_${PYTHON_SHORT}
requirements:
- docker/base-deps/requirements.in
- docker/base-extra/requirements.in
constraints:
- /tmp/ray-deps/requirements_compiled.txt
output: python/deplocks/base_extra/ray_base_extra_py${PYTHON_VERSION}.lock
append_flags:
- --unsafe-package ray
- --python-version=${PYTHON_VERSION}
- --python-platform=linux
build_arg_sets:
- py39
- py310
- py311
- py312
24 changes: 5 additions & 19 deletions docker/base-extra/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ ENV TERM=xterm

ARG SSH_PORT=5020

ARG PYTHON_DEPSET

COPY "$PYTHON_DEPSET" /home/ray/python_depset.lock

RUN <<EOF
#!/bin/bash

Expand Down Expand Up @@ -88,29 +92,11 @@ if [[ "$ARCH" == "x86_64" ]]; then
rm -rf "${DYNOLOG_TMP}"
fi

# Python dependencies to install. To specify a version, please make the change
# in OSS ray repository, but not here.
PYTHON_REQUIREMENTS=(
azure-identity
jupyterlab
ipywidgets
grpcio
grpcio-tools

# Pinning jupyter_server_terminals==0.4.4 , the higher version will break the
# webterminal when using an older version of terminado.
jupyter_server_terminals==0.4.4

# [backend] is for installing anyscale CLI for use in the anyscale cloud.
"anyscale[backend]"
)


PYTHON_VERSION="$(python -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')"

uv pip install --system --no-cache-dir --index-strategy unsafe-best-match \
-c /home/ray/requirements_compiled.txt \
"${PYTHON_REQUIREMENTS[@]}"
-r $HOME/python_depset.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are using a lock file, we can just remove the requirements_compiled.txt constraint file now?


# Install awscli v2
AWSCLI_TMP="$(mktemp -d)"
Expand Down
3 changes: 3 additions & 0 deletions docker/base-extra/cpu.wanda.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
name: "$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base-extra$ARCH_SUFFIX"
froms: ["cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base$ARCH_SUFFIX"]
dockerfile: docker/base-extra/Dockerfile
srcs:
- release/ray_release/byod/$REQUIREMENTS_FILE
build_args:
- BASE_IMAGE=cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base$ARCH_SUFFIX
- PYTHON_DEPSET=release/ray_release/byod/$REQUIREMENTS_FILE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

There seems to be an inconsistency in the path used for the requirements file. The new depset ray_base_extra generates lock files in python/deplocks/base_extra/. This file uses release/ray_release/byod/, which appears to be incorrect and will likely cause the build to fail. The path should be consistent with cuda.wanda.yaml and the depset definition in ci/raydepsets/configs/rayimg.depsets.yaml.

srcs:
  - python/deplocks/base_extra/$REQUIREMENTS_FILE
build_args:
  - BASE_IMAGE=cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base$ARCH_SUFFIX
  - PYTHON_DEPSET=python/deplocks/base_extra/$REQUIREMENTS_FILE

tags:
- cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base-extra$ARCH_SUFFIX
3 changes: 3 additions & 0 deletions docker/base-extra/cuda.wanda.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
name: "$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra$ARCH_SUFFIX"
froms: ["cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base$ARCH_SUFFIX"]
dockerfile: docker/base-extra/Dockerfile
srcs:
- python/deplocks/base_extra/$REQUIREMENTS_FILE
build_args:
- BASE_IMAGE=cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base$ARCH_SUFFIX
- PYTHON_DEPSET=python/deplocks/base_extra/$REQUIREMENTS_FILE
tags:
- cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra$ARCH_SUFFIX
2,835 changes: 2,835 additions & 0 deletions python/deplocks/base_extra/ray_base_extra_py3.10.lock

Large diffs are not rendered by default.

2,816 changes: 2,816 additions & 0 deletions python/deplocks/base_extra/ray_base_extra_py3.11.lock

Large diffs are not rendered by default.

2,787 changes: 2,787 additions & 0 deletions python/deplocks/base_extra/ray_base_extra_py3.12.lock

Large diffs are not rendered by default.

2,850 changes: 2,850 additions & 0 deletions python/deplocks/base_extra/ray_base_extra_py3.9.lock

Large diffs are not rendered by default.