-
Notifications
You must be signed in to change notification settings - Fork 7k
[images][deps] raydepsets base extra depset #58461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aslonnie
merged 7 commits into
master
from
elliot-barn/raydepsets-base-deps-extra-depset
Nov 12, 2025
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
de84cbd
first commit
elliot-barn 499cd3b
generating base extra depsets
elliot-barn 6ccc371
Merge remote-tracking branch 'origin/master' into elliot-barn/raydeps…
elliot-barn 6e3dbeb
updating path for requirements file
elliot-barn 9446fe9
setting requirements files for all images that use base extra docker
elliot-barn 9be1dda
including aarch64 depset
elliot-barn d729aa5
adding comment
elliot-barn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,10 @@ ENV TERM=xterm | |
|
|
||
| ARG SSH_PORT=5020 | ||
|
|
||
| ARG PYTHON_DEPSET | ||
|
|
||
| COPY "$PYTHON_DEPSET" /home/ray/python_depset.lock | ||
|
|
||
| RUN <<EOF | ||
| #!/bin/bash | ||
|
|
||
|
|
@@ -88,29 +92,10 @@ if [[ "$ARCH" == "x86_64" ]]; then | |
| rm -rf "${DYNOLOG_TMP}" | ||
| fi | ||
|
|
||
| # Python dependencies to install. To specify a version, please make the change | ||
| # in OSS ray repository, but not here. | ||
| PYTHON_REQUIREMENTS=( | ||
| azure-identity | ||
| jupyterlab | ||
| ipywidgets | ||
| grpcio | ||
| grpcio-tools | ||
|
|
||
| # Pinning jupyter_server_terminals==0.4.4 , the higher version will break the | ||
| # webterminal when using an older version of terminado. | ||
| jupyter_server_terminals==0.4.4 | ||
|
|
||
| # [backend] is for installing anyscale CLI for use in the anyscale cloud. | ||
| "anyscale[backend]" | ||
| ) | ||
|
|
||
|
|
||
| PYTHON_VERSION="$(python -c 'import sys; print(f"{sys.version_info.major}.{sys.version_info.minor}")')" | ||
|
|
||
| uv pip install --system --no-cache-dir --index-strategy unsafe-best-match \ | ||
| -c /home/ray/requirements_compiled.txt \ | ||
| "${PYTHON_REQUIREMENTS[@]}" | ||
| uv pip install --system --no-cache-dir --no-deps --index-strategy unsafe-best-match \ | ||
| -r $HOME/python_depset.lock | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. since we are using a lock file, we can just remove the |
||
|
|
||
| # Install awscli v2 | ||
| AWSCLI_TMP="$(mktemp -d)" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| name: "$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base-extra$ARCH_SUFFIX" | ||
| froms: ["cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base$ARCH_SUFFIX"] | ||
| dockerfile: docker/base-extra/Dockerfile | ||
| srcs: | ||
| - python/deplocks/base_extra/$REQUIREMENTS_FILE | ||
| build_args: | ||
| - BASE_IMAGE=cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base$ARCH_SUFFIX | ||
| - PYTHON_DEPSET=python/deplocks/base_extra/$REQUIREMENTS_FILE | ||
| tags: | ||
| - cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cpu-base-extra$ARCH_SUFFIX |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| name: "$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra$ARCH_SUFFIX" | ||
| froms: ["cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base$ARCH_SUFFIX"] | ||
| dockerfile: docker/base-extra/Dockerfile | ||
| srcs: | ||
| - python/deplocks/base_extra/$REQUIREMENTS_FILE | ||
| build_args: | ||
| - BASE_IMAGE=cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base$ARCH_SUFFIX | ||
| - PYTHON_DEPSET=python/deplocks/base_extra/$REQUIREMENTS_FILE | ||
| tags: | ||
| - cr.ray.io/rayproject/$IMAGE_TYPE-py$PYTHON_VERSION-cu$CUDA_VERSION-base-extra$ARCH_SUFFIX |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you add some comment that explains why this is a subset?