Skip to content

[wheel] fix windows wheel building #58343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aslonnie merged 1 commit into from
Oct 31, 2025
Merged

[wheel] fix windows wheel building #58343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 18 additions & 40 deletions python/build-wheel-windows.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,33 +53,15 @@ EOF
source "$TEMP/refreshenv.sh"
}

install_ray() {
# TODO(mehrdadn): This function should be unified with the one in ci/ci.sh.
(
pip install wheel delvewheel


pushd python/ray/dashboard/client
choco install nodejs --version=22.4.1 -y
refreshenv
# https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported
export NODE_OPTIONS=--openssl-legacy-provider
npm install
npm run build
popd

cd "${WORKSPACE_DIR}"/python
pip install -v -e .
)
}

uninstall_ray() {
pip uninstall -y ray

# Cleanup generated thirdparty files.
python -c $'import shutil; import sys; \nfor d in sys.argv[1:]: shutil.rmtree(d, ignore_errors=True);' \
"${ROOT_DIR}/ray/thirdparty_files" \
"${ROOT_DIR}/ray/_private/runtime_env/agent/thirdparty_files"
build_dashboard() {
pushd python/ray/dashboard/client
choco install nodejs --version=22.4.1 -y
refreshenv
# https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported
export NODE_OPTIONS=--openssl-legacy-provider
npm install
npm run build
popd
}

build_wheel_windows() {
Expand All @@ -88,9 +70,6 @@ build_wheel_windows() {
exit 1
fi

local ray_uninstall_status=0
uninstall_ray || ray_uninstall_status=1

local local_dir="python/dist"
{
echo "build --announce_rc";
Expand Down Expand Up @@ -119,28 +98,27 @@ build_wheel_windows() {
fi

unset PYTHON2_BIN_PATH PYTHON3_BIN_PATH # make sure these aren't set by some chance
install_ray
build_dashboard

python -m pip install pip==25.2
python -m pip install wheel==0.45.1 delvewheel==1.11.2 setuptools==80.9.0
Comment on lines +103 to +104
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

These two pip install commands can be combined into a single one for better efficiency. This reduces the number of pip invocations and allows pip to perform dependency resolution for all packages at once.

Suggested change
python -m pip install pip==25.2
python -m pip install wheel==0.45.1 delvewheel==1.11.2 setuptools==80.9.0
python -m pip install pip==25.2 wheel==0.45.1 delvewheel==1.11.2 setuptools==80.9.0


cd "${WORKSPACE_DIR}"/python
# Set the commit SHA in _version.py.
if [ -n "$BUILDKITE_COMMIT" ]; then
if [[ -n "${BUILDKITE_COMMIT:-}" ]]; then
sed -i.bak "s/{{RAY_COMMIT_SHA}}/$BUILDKITE_COMMIT/g" ray/_version.py && rm ray/_version.py.bak
else
echo "BUILDKITE_COMMIT variable not set - required to populated ray.__commit__."
exit 1
fi

# build ray wheel
python -m pip wheel -v -w dist . --no-deps
python -m pip wheel -v -w dist . --no-deps --use-pep517
# Pack any needed system dlls like msvcp140.dll
delvewheel repair dist/ray-*.whl
# build ray-cpp wheel
RAY_INSTALL_CPP=1 python -m pip wheel -v -w dist . --no-deps
# No extra dlls are needed, do not call delvewheel
uninstall_ray
RAY_INSTALL_CPP=1 python -m pip wheel -v -w dist . --no-deps --use-pep517
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the ray wheel build command on line 116 and for better debuggability, consider adding the --debug flag to this command as well. It will provide more verbose output, which is helpful for diagnosing CI failures.

Suggested change
RAY_INSTALL_CPP=1 python -m pip wheel -v -w dist . --no-deps --use-pep517
RAY_INSTALL_CPP=1 python -m pip wheel -v -w dist . --no-deps --debug --use-pep517

)

if [ 0 -eq "${ray_uninstall_status}" ]; then # If Ray was previously installed, restore it
install_ray
fi
}

build_wheel_windows "$@"