[core] (cgroups 21/n) Do not move dashboard modules into the workers cgroup even if they are drivers #57955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgroup even if they are drivers Signed-off-by: irabbani <[email protected]>
israbbani
added
core
Signed-off-by: irabbani <[email protected]>
Signed-off-by: irabbani <[email protected]>
israbbani
commented
Oct 22, 2025
| def get_pid(self): | ||
| return os.getpid() | ||
|
|
||
| second_driver_proc = create_driver_in_internal_namespace() |
Contributor
Author
There was a problem hiding this comment.
I only added the test to ray start because in ray.init, the testing process is a driver that is already in the workers cgroup. Therefore, the newly spawned second driver will also be in the workers cgroup.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| runner.invoke(scripts.stop) | ||
| assert_process_in_not_moved_into_ray_cgroups( | ||
| node_id, resource_isolation_config, second_driver_proc.pid | ||
| ) |
There was a problem hiding this comment.
Bug: Test Assertion Fails Due to PID Type Mismatch
The assert_process_in_not_moved_into_ray_cgroups function expects a string PID but receives an integer from second_driver_proc.pid. This type mismatch causes the internal PID comparison to always fail, making the test assertion ineffective and always pass.
edoakes
approved these changes
Oct 22, 2025
| ) | ||
|
|
||
|
|
||
| def assert_process_in_not_moved_into_ray_cgroups( |
Collaborator
There was a problem hiding this comment.
did you forget a word in the name?
| node_id: used to construct the path of the cgroup subtree | ||
| resource_isolation_config: used to construct the path of the cgroup | ||
| subtree | ||
| pid: |
| """ | ||
| import ray | ||
| import time | ||
| ray.init(namespace='_ray_internal_') |
Collaborator
There was a problem hiding this comment.
there's a constant for it somewhere you could use, but hard coding is also fine (it shouldn't change)
israbbani
added a commit
that referenced
this pull request
Oct 22, 2025
…cgroup even if they are drivers (#57955) For more details about the resource isolation project see #54703. Driver processes that are registered in ray's internal namespace (such as ray dashboard's job and serve modules) are considered system processes. Therefore, they will not be moved into the workers cgroup when they register with the raylet. --------- Signed-off-by: irabbani <[email protected]>
aslonnie
pushed a commit
that referenced
this pull request
Oct 22, 2025
Cherrypicking #57955 into v2.51.0 Signed-off-by: irabbani <[email protected]>
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 27, 2025
…cgroup even if they are drivers (ray-project#57955) For more details about the resource isolation project see ray-project#54703. Driver processes that are registered in ray's internal namespace (such as ray dashboard's job and serve modules) are considered system processes. Therefore, they will not be moved into the workers cgroup when they register with the raylet. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: xgui <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…cgroup even if they are drivers (ray-project#57955) For more details about the resource isolation project see ray-project#54703. Driver processes that are registered in ray's internal namespace (such as ray dashboard's job and serve modules) are considered system processes. Therefore, they will not be moved into the workers cgroup when they register with the raylet. --------- Signed-off-by: irabbani <[email protected]>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…cgroup even if they are drivers (ray-project#57955) For more details about the resource isolation project see ray-project#54703. Driver processes that are registered in ray's internal namespace (such as ray dashboard's job and serve modules) are considered system processes. Therefore, they will not be moved into the workers cgroup when they register with the raylet. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…cgroup even if they are drivers (ray-project#57955) For more details about the resource isolation project see ray-project#54703. Driver processes that are registered in ray's internal namespace (such as ray dashboard's job and serve modules) are considered system processes. Therefore, they will not be moved into the workers cgroup when they register with the raylet. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more details about the resource isolation project see #54703.
Driver processes that are registered in ray's internal namespace (such as ray dashboard's job and serve modules) are considered system processes. Therefore, they will not be moved into the workers cgroup when they register with the raylet.