[deps][ci] Creating depset for docs & updating pydantic doc ver #57947

elliot-barn · 2025-10-21T07:35:21Z

creating a depset for doc builds
Pinning pydantic==2.50 for doc requirements due to api_policy_check failing due to dependencies (failure below)
Installing ray without deps

Failure due to dependencies: https://buildkite.com/ray-project/premerge/builds/52231#019a04a9-e9f8-4151-b5e5-d4bceb48a3cc

Successful api_policy_check run on this PR: https://buildkite.com/ray-project/microcheck/builds/29312#019a05b8-ef40-4449-9ca2-6dd9d8e790a7

Signed-off-by: elliot-barn <[email protected]>

…ect/ray into elliot-barn/depset-for-docbuild

Signed-off-by: elliot-barn <[email protected]>

aslonnie

nice work! this will make doc building a bit more stable!

some comments on small things.

aslonnie · 2025-10-21T17:31:00Z

ci/docker/doc.build.Dockerfile

-
 COPY . .

+RUN mv python/deplocks/docs/docbuild_depset_py${PYTHON}.lock python_depset.lock


why do you need to make the move here? why not just do the pip install directly with the file name down at line 29?

it is a little bit confusing on where the python_depset.lock file comes from if just reading line 29.

this follows the pattern we use for byod. All images will eventually install python dependencies from python_depset.lock

updated to just install the lock file directly

yeah, this is a CI base file, it is different from the release test byod images.

aslonnie · 2025-10-21T17:34:06Z

ci/lint/lint.sh

  fi
 }

+_install_ray_no_deps() {


you changed the only two places that were using _install_ray to run _install_ray_no_deps, maybe just remove the _install_ray function?

aslonnie · 2025-10-21T17:36:06Z

.buildkite/dependencies.rayci.yml

    job_env: manylinux
    depends_on: manylinux
+
+  - label: ":tapioca: build: raydepsets: compile doc dependencies"


we should think about merging some of those into one single test job. those are rather fast checks, they do not justify the overhead of spinning up separate test job instances.

sounds good to me

aslonnie · 2025-10-21T17:36:10Z

ci/docker/doc.build.Dockerfile

 cp /mnt/ray-dashboard/dashboard.tar.gz /opt/ray-build/dashboard.tar.gz

-pip install -r doc/requirements-doc.txt
+pip install -r python_depset.lock


could you check if readthedocs is also using the lock file? let's make sure that it is consistent with how CI builds the doc.

Updated here: https://github.com/ray-project/ray/pull/57947/files#diff-03efc769b870804394632e45d7885272b44c16939517fb31c9d7c614d2ffae57R23

python/deplocks/docs/docbuild_depset_py3.10.lock

.buildkite/base.rayci.yml

Signed-off-by: elliot-barn <[email protected]>

aslonnie · 2025-10-21T21:59:01Z

.readthedocs.yaml

 python:
  install:
-    - requirements: doc/requirements-doc.txt
+    - requirements: python/deplocks/docs/docbuild_depset_py3.12.lock


creating a depset for doc builds Pinning pydantic==2.50 for doc requirements due to api_policy_check failing due to dependencies (failure below) Installing ray without deps Failure due to dependencies: https://buildkite.com/ray-project/premerge/builds/52231#019a04a9-e9f8-4151-b5e5-d4bceb48a3cc Successful api_policy_check run on this PR: https://buildkite.com/ray-project/microcheck/builds/29312#019a05b8-ef40-4449-9ca2-6dd9d8e790a7 --------- Signed-off-by: elliot-barn <[email protected]> Co-authored-by: Lonnie Liu <[email protected]> Signed-off-by: elliot-barn <[email protected]>

…project#57947) creating a depset for doc builds Pinning pydantic==2.50 for doc requirements due to api_policy_check failing due to dependencies (failure below) Installing ray without deps Failure due to dependencies: https://buildkite.com/ray-project/premerge/builds/52231#019a04a9-e9f8-4151-b5e5-d4bceb48a3cc Successful api_policy_check run on this PR: https://buildkite.com/ray-project/microcheck/builds/29312#019a05b8-ef40-4449-9ca2-6dd9d8e790a7 --------- Signed-off-by: elliot-barn <[email protected]> Co-authored-by: Lonnie Liu <[email protected]>

…project#57947) creating a depset for doc builds Pinning pydantic==2.50 for doc requirements due to api_policy_check failing due to dependencies (failure below) Installing ray without deps Failure due to dependencies: https://buildkite.com/ray-project/premerge/builds/52231#019a04a9-e9f8-4151-b5e5-d4bceb48a3cc Successful api_policy_check run on this PR: https://buildkite.com/ray-project/microcheck/builds/29312#019a05b8-ef40-4449-9ca2-6dd9d8e790a7 --------- Signed-off-by: elliot-barn <[email protected]> Co-authored-by: Lonnie Liu <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>

…project#57947) creating a depset for doc builds Pinning pydantic==2.50 for doc requirements due to api_policy_check failing due to dependencies (failure below) Installing ray without deps Failure due to dependencies: https://buildkite.com/ray-project/premerge/builds/52231#019a04a9-e9f8-4151-b5e5-d4bceb48a3cc Successful api_policy_check run on this PR: https://buildkite.com/ray-project/microcheck/builds/29312#019a05b8-ef40-4449-9ca2-6dd9d8e790a7 --------- Signed-off-by: elliot-barn <[email protected]> Co-authored-by: Lonnie Liu <[email protected]> Signed-off-by: Future-Outlier <[email protected]>

elliot-barn and others added 20 commits October 17, 2025 00:31

including lock files for doc builds

1937054

Signed-off-by: elliot-barn <[email protected]>

updating p39 to py310

d42ea10

Signed-off-by: elliot-barn <[email protected]>

adding lock file

34b078d

Signed-off-by: elliot-barn <[email protected]>

including base build for py3.10

34b7430

Signed-off-by: elliot-barn <[email protected]>

merging master

4594163

Signed-off-by: elliot-barn <[email protected]>

including 3.10 base test image

bbf4906

Signed-off-by: elliot-barn <[email protected]>

reverting copy command

2d514a7

Signed-off-by: elliot-barn <[email protected]>

renaming depset lock file

a71114b

Signed-off-by: elliot-barn <[email protected]>

updating pip command

16adde9

Signed-off-by: elliot-barn <[email protected]>

removing quotes from docker build arg

0f977d9

Signed-off-by: elliot-barn <[email protected]>

echoing pip requirements

ab72f73

Signed-off-by: elliot-barn <[email protected]>

expanding ray img depset and updating docbuild requirements file

1132033

Signed-off-by: elliot-barn <[email protected]>

Merge branch 'master' into elliot-barn/depset-for-docbuild

7d80ff4

using relative path to lock file

eea5391

Signed-off-by: elliot-barn <[email protected]>

Merge branch 'elliot-barn/depset-for-docbuild' of github.com:ray-proj…

30733c7

…ect/ray into elliot-barn/depset-for-docbuild

running on python 3.9

d8db64d

Signed-off-by: elliot-barn <[email protected]>

building 3.9 docbuild

e63d4bb

Signed-off-by: elliot-barn <[email protected]>

lockfile for python 3.9

06d9534

Signed-off-by: elliot-barn <[email protected]>

installing ray without deps

8df0368

Signed-off-by: elliot-barn <[email protected]>

updgrading pydantic constraint

47d1fa7

Signed-off-by: elliot-barn <[email protected]>

elliot-barn requested a review from aslonnie October 21, 2025 15:51

elliot-barn marked this pull request as ready for review October 21, 2025 15:51

elliot-barn requested review from a team as code owners October 21, 2025 15:51

elliot-barn added the go add ONLY when ready to merge, run all tests label Oct 21, 2025

elliot-barn changed the title ~~[deps][ci] updating pydantic doc ver~~ [deps][ci] Creating depset for docs & updating pydantic doc ver Oct 21, 2025

This comment was marked as outdated.

Sign in to view

aslonnie reviewed Oct 21, 2025

View reviewed changes

python/deplocks/docs/docbuild_depset_py3.10.lock Show resolved Hide resolved

.buildkite/base.rayci.yml Outdated Show resolved Hide resolved

removing python 310 builds

6a9601a

Signed-off-by: elliot-barn <[email protected]>

elliot-barn added 2 commits October 21, 2025 17:53

removing install ray

ab2ec89

Signed-off-by: elliot-barn <[email protected]>

removing markdown-it-py pin

c72eded

Signed-off-by: elliot-barn <[email protected]>

aslonnie self-requested a review October 21, 2025 19:03

ray-gardener bot added docs An issue or change related to documentation core Issues that should be addressed in Ray Core devprod labels Oct 21, 2025

aslonnie approved these changes Oct 21, 2025

View reviewed changes

aslonnie reviewed Oct 21, 2025

View reviewed changes

aslonnie merged commit e51f803 into master Oct 21, 2025
6 checks passed

aslonnie deleted the elliot-barn/updating-pydantic-doc-ver branch October 21, 2025 21:59


		COPY . .

		RUN mv python/deplocks/docs/docbuild_depset_py${PYTHON}.lock python_depset.lock

[deps][ci] Creating depset for docs & updating pydantic doc ver #57947

[deps][ci] Creating depset for docs & updating pydantic doc ver #57947

Uh oh!

Conversation

elliot-barn commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

aslonnie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

elliot-barn commented Oct 21, 2025 •

edited

Loading