[tracing] Update OpenTelemetry dependencies and fixing doc to make tracing work #57908
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng for tracing setup Signed-off-by: justwph <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenTelemetry dependencies to more recent versions and fixes the documentation and error messages to ensure tracing can be set up correctly. The changes look good and address the staleness of the tracing setup. I've suggested a couple of minor improvements for consistency between the documentation and error messages, and to make the installation instructions more concise for users.
Comment on lines
+18
to
+20
| pip install opentelemetry-api==1.34.1 | ||
| pip install opentelemetry-sdk==1.34.1 | ||
| pip install opentelemetry-exporter-otlp==1.34.1 |
Contributor
There was a problem hiding this comment.
For conciseness and to ensure atomic installation of compatible versions, it's better to combine these pip install commands into a single line.
Suggested change
| pip install opentelemetry-api==1.34.1 | |
| pip install opentelemetry-sdk==1.34.1 | |
| pip install opentelemetry-exporter-otlp==1.34.1 | |
| pip install opentelemetry-api==1.34.1 opentelemetry-sdk==1.34.1 opentelemetry-exporter-otlp==1.34.1 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: JustWPH <[email protected]>
ray-gardener
bot
added
usability
docs
Collaborator
|
Kicked off full CI run: https://buildkite.com/ray-project/premerge/builds/52141 The PR will auto-merge if it passes. If not, please ping me once tests are passing. |
dayshah
approved these changes
Oct 21, 2025
xinyuangui2
pushed a commit
to xinyuangui2/ray
that referenced
this pull request
Oct 22, 2025
…acing work (ray-project#57908) Tracing code hasn’t been maintained, and it can’t be run by relying on the docs alone. 1. [https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation](https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation) `opentelemetry-api==1.1.0` Version 1.1.0 is too old— https://github.com/ray-project/ray/blob/b988ce4e9b0fb618b40865600c0d98f1714c3bcf/ci/docker/serve.build.Dockerfile#L47 we’re already using 1.3.0+, which is incompatible with 1.1.0. 2. A legacy issue? This prevents the help information from being displayed. --------- Signed-off-by: justwph <[email protected]> Signed-off-by: JustWPH <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: xgui <[email protected]>
elliot-barn
pushed a commit
that referenced
this pull request
Oct 23, 2025
…acing work (#57908) Tracing code hasn’t been maintained, and it can’t be run by relying on the docs alone. 1. [https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation](https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation) `opentelemetry-api==1.1.0` Version 1.1.0 is too old— https://github.com/ray-project/ray/blob/b988ce4e9b0fb618b40865600c0d98f1714c3bcf/ci/docker/serve.build.Dockerfile#L47 we’re already using 1.3.0+, which is incompatible with 1.1.0. 2. A legacy issue? This prevents the help information from being displayed. --------- Signed-off-by: justwph <[email protected]> Signed-off-by: JustWPH <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: elliot-barn <[email protected]>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…acing work (ray-project#57908) Tracing code hasn’t been maintained, and it can’t be run by relying on the docs alone. 1. [https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation](https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation) `opentelemetry-api==1.1.0` Version 1.1.0 is too old— https://github.com/ray-project/ray/blob/b988ce4e9b0fb618b40865600c0d98f1714c3bcf/ci/docker/serve.build.Dockerfile#L47 we’re already using 1.3.0+, which is incompatible with 1.1.0. 2. A legacy issue? This prevents the help information from being displayed. --------- Signed-off-by: justwph <[email protected]> Signed-off-by: JustWPH <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…acing work (ray-project#57908) Tracing code hasn’t been maintained, and it can’t be run by relying on the docs alone. 1. [https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation](https://docs.ray.io/en/latest/ray-observability/user-guides/ray-tracing.html#installation) `opentelemetry-api==1.1.0` Version 1.1.0 is too old— https://github.com/ray-project/ray/blob/b988ce4e9b0fb618b40865600c0d98f1714c3bcf/ci/docker/serve.build.Dockerfile#L47 we’re already using 1.3.0+, which is incompatible with 1.1.0. 2. A legacy issue? This prevents the help information from being displayed. --------- Signed-off-by: justwph <[email protected]> Signed-off-by: JustWPH <[email protected]> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Aydin Abiar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracing code hasn’t been maintained, and it can’t be run by relying on the docs alone.
opentelemetry-api==1.1.0Version 1.1.0 is too old—
ray/ci/docker/serve.build.Dockerfile
Line 47 in b988ce4
we’re already using 1.3.0+, which is incompatible with 1.1.0.
A legacy issue? This prevents the help information from being displayed.