Address pull request review comments #57836
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds documentation for the external scaling webhook, allowing programmatic scaling of deployments via a REST API. Updates application configuration and advanced guides. Co-authored-by: harshit <[email protected]>
|
Cursor Agent can help with this pull request. Just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses review comments on the external scaling webhook documentation. It moves the content to the advanced autoscaling guide, condenses the explanation, updates the Python example, and clarifies the mutual exclusivity with built-in autoscaling.
Related issues
Related to #57698
Additional information
doc/source/serve/advanced-guides/advanced-autoscaling.md.response.raise_for_status()for robust error checking.doc/source/serve/production-guide/config.mdto includeexternal_scaler_enabledand link to the new section.