Skip to content

Conversation

@elliot-barn
Copy link
Contributor

@elliot-barn elliot-barn commented Sep 30, 2025

running core scalability tests on python 3.10
Updating unit test
Successful release test: https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3


Note

Allows GPU BYOD tests on Python 3.10 and sets core scalability tests to Python 3.10, adding a unit test for parsing with python field.

  • Config/Validation:
    • Update validate_byod_type to allow byod_type="gpu" with Python "3.9" or "3.10".
  • Release Tests:
    • Set python: "3.10" for core scalability tests in release/release_tests.yaml (e.g., single_node, object_store, small_objects, large_objects, many_actors, many_tasks, many_pgs, many_nodes, scheduling_test_many_0s_tasks_many_nodes, and related smoke/GCE variants).
  • Unit Tests:
    • Add test_parse_test_definition_with_python_version to verify parsing of variations with a python field.

Written by Cursor Bugbot for commit 0907c42. This will update automatically on new commits. Configure here.

@elliot-barn elliot-barn marked this pull request as ready for review September 30, 2025 23:39
@elliot-barn elliot-barn requested a review from a team as a code owner September 30, 2025 23:39
Signed-off-by: elliot-barn <[email protected]>
@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core release-test release test labels Oct 1, 2025
parse_test_definition([invalid_test_definition])


def test_parse_test_definition_with_python_version():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you separate this (and the config change) into another PR?

#########################

- name: single_node
python: "3.10"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems misconfigured to run on ray-ml / gpu type image. could you see if the test still passes on ray / cpu image?

other tests that are using gpu type image too.

it might be the case that they just need to run on a cuda image.

cc @jjyao @edoakes

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of them are just copy-paste mistakes. I can check

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah looks like basically all of the core ones don't actually need type: gpu... @elliot-barn could you try a test run where you swap them to CPU images?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little late but they should be running on cpu images and looks like they all passed.

https://buildkite.com/ray-project/release/builds/64811

@elliot-barn elliot-barn changed the title [release] Running core stability tests on python 3.10 [release] Running core scalibility tests on python 3.10 Oct 3, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 17, 2025
@aslonnie aslonnie removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Oct 21, 2025
@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Oct 22, 2025
@aslonnie
Copy link
Collaborator

will merge this after 2.51 branch cut.

@aslonnie aslonnie enabled auto-merge (squash) October 22, 2025 21:55
@aslonnie aslonnie merged commit 2f8e3f0 into master Oct 22, 2025
8 checks passed
@aslonnie aslonnie deleted the elliot-barn/py310-core-stability-tests branch October 22, 2025 21:55
xinyuangui2 pushed a commit to xinyuangui2/ray that referenced this pull request Oct 27, 2025
…57044)

running core scalability tests on python 3.10
Updating unit test
Successful release test:
https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3

---------

Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: xgui <[email protected]>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
…57044)

running core scalability tests on python 3.10
Updating unit test
Successful release test:
https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3

---------

Signed-off-by: elliot-barn <[email protected]>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
…57044)

running core scalability tests on python 3.10
Updating unit test
Successful release test:
https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3

---------

Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: Aydin Abiar <[email protected]>
Future-Outlier pushed a commit to Future-Outlier/ray that referenced this pull request Dec 7, 2025
…57044)

running core scalability tests on python 3.10
Updating unit test
Successful release test:
https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3

---------

Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests release-test release test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants