-
Notifications
You must be signed in to change notification settings - Fork 7k
[release] Running core scalibility tests on python 3.10 #57044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
…ot-barn/py310-core-stability-tests
…ore-stability-tests
Signed-off-by: elliot-barn <[email protected]>
Signed-off-by: elliot-barn <[email protected]>
| parse_test_definition([invalid_test_definition]) | ||
|
|
||
|
|
||
| def test_parse_test_definition_with_python_version(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you separate this (and the config change) into another PR?
| ######################### | ||
|
|
||
| - name: single_node | ||
| python: "3.10" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most of them are just copy-paste mistakes. I can check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah looks like basically all of the core ones don't actually need type: gpu... @elliot-barn could you try a test run where you swap them to CPU images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A little late but they should be running on cpu images and looks like they all passed.
Signed-off-by: elliot-barn <[email protected]>
…ay-project/ray into elliot-barn/py310-core-stability-tests
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
…ore-stability-tests
|
will merge this after 2.51 branch cut. |
…57044) running core scalability tests on python 3.10 Updating unit test Successful release test: https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3 --------- Signed-off-by: elliot-barn <[email protected]> Signed-off-by: xgui <[email protected]>
…57044) running core scalability tests on python 3.10 Updating unit test Successful release test: https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3 --------- Signed-off-by: elliot-barn <[email protected]>
…57044) running core scalability tests on python 3.10 Updating unit test Successful release test: https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3 --------- Signed-off-by: elliot-barn <[email protected]> Signed-off-by: Aydin Abiar <[email protected]>
…57044) running core scalability tests on python 3.10 Updating unit test Successful release test: https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3 --------- Signed-off-by: elliot-barn <[email protected]> Signed-off-by: Future-Outlier <[email protected]>
running core scalability tests on python 3.10
Updating unit test
Successful release test: https://buildkite.com/ray-project/release/builds/60890#01999c8a-6fdc-446a-a9da-2b9b006692d3
Note
Allows GPU BYOD tests on Python 3.10 and sets core scalability tests to Python 3.10, adding a unit test for parsing with python field.
validate_byod_typeto allowbyod_type="gpu"with Python"3.9"or"3.10".python: "3.10"for core scalability tests inrelease/release_tests.yaml(e.g.,single_node,object_store,small_objects,large_objects,many_actors,many_tasks,many_pgs,many_nodes,scheduling_test_many_0s_tasks_many_nodes, and related smoke/GCE variants).test_parse_test_definition_with_python_versionto verify parsing ofvariationswith apythonfield.Written by Cursor Bugbot for commit 0907c42. This will update automatically on new commits. Configure here.