[core] (cgroups 7/n) cleaning up old cgroup integration code for raylet and core worker #56285
+7
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and core worker Signed-off-by: irabbani <[email protected]>
israbbani
added
core
16 tasks
Signed-off-by: irabbani <[email protected]>
Signed-off-by: Ibrahim Rabbani <[email protected]>
edoakes
approved these changes
Sep 9, 2025
ZacAttack
pushed a commit
that referenced
this pull request
Sep 11, 2025
This PR stacks on #56285. For more details about the resource isolation project see #54703. This PR integrates the CgroupManager with the raylet startup in `main.cc`. It includes - A cross-platform cgroup_manager bazel target that selectively compiles dependencies for linux/non-linux platforms. I prefer this design because it keeps targets small and compile times low and removes unnecessary ifdefs from the code. - Adds the following command-line args to the raylet binary - enable_resource_isolation - cgroup_path - system_reserved_cpu_weight - system_reserved_memory_bytes I've left comments on the PR to highlight parts that could use some feedback/discussion. --------- Signed-off-by: irabbani <[email protected]> Signed-off-by: Ibrahim Rabbani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stacks on #56260.
For more details about the resource isolation project see #54703.
This PR removes previous code for integrating resource isolation with the raylet and core worker. It's a prerequisite for integrating the CgroupManager with the raylet.
This PR is cleanup only and there is no behavior change.