Revert "Route core worker ERROR/FATAL logs to driver logs (#18577)" #18602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krfricke
approved these changes
Sep 14, 2021
Collaborator
Author
|
Failures in docker builds look related to build infra (also happening on other PRs) & the relevant test is passing, so merging to avoid failures in master. |
ericl
added a commit
to ericl/ray
that referenced
this pull request
Sep 14, 2021
…y-project#18577)" (ray-project#18602)" This reverts commit 7f8cdce.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3e0ae38.
Why are these changes needed?
Seems to have been a conflict between two merged PRs causing test failures in master:
https://buildkite.com/ray-project/ray-builders-branch/builds/3410#30ca9606-ff3e-46b5-a8de-4a575556f1ed/208-686
Confirmed passing locally after reverting.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.