Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The project setup.py script doesn't install tools needed by ci/travis/format.sh #6999

Open
deanwampler opened this issue Feb 1, 2020 · 1 comment
Open

The project setup.py script doesn't install tools needed by ci/travis/format.sh #6999

deanwampler opened this issue Feb 1, 2020 · 1 comment
Labels
enhancement Request for new feature and/or capability P3 Issue moderate in impact or severity

Comments

@deanwampler
Copy link
Contributor

When you attempt to push local work upstream, ci/travis/format.sh is executed. It expects to find:

  • yapf version 0.23.0
  • flake8 version 3.7.7
  • clang_format version 7.0.0

It would nice if setup.py installed the first two with pip and checked that the installed version of clang_format is what's expected.
@deanwampler deanwampler added the bug Something that is supposed to be working; but isn't label Feb 1, 2020
@deanwampler deanwampler mentioned this issue Feb 3, 2020
Merged
3 tasks
@deanwampler
Copy link
Contributor Author

#7026 partially addresses this issue with documentation, but not automation.

@edoakes edoakes added enhancement Request for new feature and/or capability and removed bug Something that is supposed to be working; but isn't labels Feb 6, 2020
@ericl ericl added the P3 Issue moderate in impact or severity label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Request for new feature and/or capability P3 Issue moderate in impact or severity
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@deanwampler @ericl @edoakes