Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Handle transient network error for pushing object chunks #50803

Open
jjyao opened this issue Feb 21, 2025 · 0 comments
Open

[Core] Handle transient network error for pushing object chunks #50803

jjyao opened this issue Feb 21, 2025 · 0 comments
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core core-object-store P1 Issue that should be fixed within a few weeks

Comments

@jjyao
Copy link
Collaborator

jjyao commented Feb 21, 2025

What happened + What you expected to happen

void ObjectManager::HandleSendFinished(const ObjectID &object_id,
                                       const NodeID &node_id,
                                       uint64_t chunk_index,
                                       double start_time,
                                       double end_time,
                                       ray::Status status) {
  RAY_LOG(DEBUG).WithField(object_id)
      << "HandleSendFinished on " << self_node_id_ << " to " << node_id
      << " of object, chunk " << chunk_index << ", status: " << status.ToString();
  if (!status.ok()) {
    // TODO(rkn): What do we want to do if the send failed?
    RAY_LOG(DEBUG).WithField(object_id).WithField(node_id)
        << "Failed to send a push request for an object to node. Chunk index: "
        << chunk_index;
  }
}

We should fix this TODO using retryable_grpc_client

Versions / Dependencies

master

Reproduction script

N/A

Issue Severity

None

@jjyao jjyao added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core core-object-store P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't core Issues that should be addressed in Ray Core core-object-store P1 Issue that should be fixed within a few weeks
Projects
None yet
Development

No branches or pull requests

1 participant