Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Callbacks class input check is invalid for new api stack #50135

Open
n30111 opened this issue Jan 30, 2025 · 0 comments
Open

[RLlib] Callbacks class input check is invalid for new api stack #50135

n30111 opened this issue Jan 30, 2025 · 0 comments
Labels
bug Something that is supposed to be working; but isn't rllib RLlib related issues triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@n30111
Copy link
Contributor

n30111 commented Jan 30, 2025

What happened + What you expected to happen

For the new api stack, callback class can be a list of callbacks, but there is validation check in the code that does not allow user to pass a list. Disabling the check for the new api stack will resolve the issue.

https://github.com/ray-project/ray/blob/master/rllib/algorithms/algorithm_config.py#L2421
Incorrect validation: https://github.com/ray-project/ray/blob/master/rllib/algorithms/algorithm_config.py#L2518

Versions / Dependencies

Master branch, python3.10 linux

Reproduction script

N/A

Issue Severity

High: It blocks me from completing my task.

@n30111 n30111 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Jan 30, 2025
@jcotant1 jcotant1 added the rllib RLlib related issues label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't rllib RLlib related issues triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

No branches or pull requests

2 participants