Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Discussion to support Valkey instead of or alongside Redis #44641

Open
dtaivpp opened this issue Apr 10, 2024 · 2 comments
Open

[Core] Discussion to support Valkey instead of or alongside Redis #44641

dtaivpp opened this issue Apr 10, 2024 · 2 comments
Assignees
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical

Comments

@dtaivpp
Copy link

dtaivpp commented Apr 10, 2024

Description

Discussion thread for whether to support Valkey

With the change of Redis' licensing many users may not be able to deploy Redis due to company policy. I wanted to start a discussion thread to see if Ray should move to support Valkey alongside Redis or instead of Redis.

I am not overly familiar with Ray's core but with a quick look it seems the code as ~200 references to Redis. I think out the gate supporting Valkey and Redis both may be fairly straightforward however as Valkey matures it may deprecate API's supported by Redis and the other way around.

Context for those not familiar: Redis has moved from a OSI approved open source license to a dual license model with RSALv2 and SSPL. These licenses prohibit companies from running Redis as a service without paying appropriate license fees. While many companies may still run it there are many more who will be unwilling to take the risk (from my experience with the Elasticsearch -> OpenSearch fork).

I think supporting Valkey is important to ensure that users are able to freely adopt Ray but wanted to get others thoughts.

Edit:
I forgot to mention this work probably does not to be immediate as Valkey has only just recently been formed but it is likely going to be the primary distribution going forward supported by AWS, Google Cloud, and Oracle due to the license change. See Linux Foundation thread: https://www.linuxfoundation.org/press/linux-foundation-launches-open-source-valkey-community

@dtaivpp dtaivpp added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Apr 10, 2024
@anyscalesam anyscalesam added the core Issues that should be addressed in Ray Core label May 13, 2024
@jjyao jjyao added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) labels May 13, 2024
@anyscalesam anyscalesam added P2 Important issue, but not time-critical and removed P1 Issue that should be fixed within a few weeks labels May 13, 2024
@anyscalesam
Copy link
Contributor

thanks for raising this @dtaivpp > valkey's a bit new but we understand the friction point on the new redis license. will make a call on when we add this support (i think it'll most likely be a when and not if) for our next 6w sprint planning.

@anyscalesam anyscalesam self-assigned this May 13, 2024
@dtaivpp
Copy link
Author

dtaivpp commented May 14, 2024

Sounds good to me. Just my two cents, if it's possible I think it would be best to support both if you all can swing it. For the self-hosters I feel like Valkey is going to be the go to option. At least for the next few years though I feel like most people will keep redis. I imagine they will change in their core features at some point which would make it handy to have an adapter that can support either or.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core enhancement Request for new feature and/or capability P2 Important issue, but not time-critical
Projects
None yet
Development

No branches or pull requests

3 participants