Backend timing statements should be made type safe.

[robertnishihara]

These methods

ray/src/ray/util/util.h

Lines 18 to 42 in e0bf9d7

	inline int64_t current_time_ms() {
	std::chrono::milliseconds ms_since_epoch =
	std::chrono::duration_cast<std::chrono::milliseconds>(
	std::chrono::steady_clock::now().time_since_epoch());
	return ms_since_epoch.count();
	}
	inline int64_t current_sys_time_ms() {
	std::chrono::milliseconds ms_since_epoch =
	std::chrono::duration_cast<std::chrono::milliseconds>(
	std::chrono::system_clock::now().time_since_epoch());
	return ms_since_epoch.count();
	}
	inline int64_t current_sys_time_us() {
	std::chrono::microseconds mu_since_epoch =
	std::chrono::duration_cast<std::chrono::microseconds>(
	std::chrono::system_clock::now().time_since_epoch());
	return mu_since_epoch.count();
	}
	inline double current_sys_time_seconds() {
	int64_t microseconds_in_seconds = 1000000;
	return static_cast<double>(current_sys_time_us()) / microseconds_in_seconds;
	}

should return actual "time" types instead of casting them to int64_t and arithmetic should be done directly on the time types to prevent errors.

[stale]

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

• If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
• If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

[robertnishihara]

Perhaps low priority, but still relevant and probably still a good idea.

[2SkeePeR2]

Hi, I would like to work on this issue. Can you please tell me in what format I should convert the int64_t? The count finally returns int64_t as the return type. Also, the issue needs arithmetic to be done based on this. So do I need to change some other functions too?

Also it looks like current_sys_time_seconds() is missing.