Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Owernership-based Object Directory - remove GCS-based object directory, add OBOD unit tests #12550

Closed
clarkzinzow opened this issue Dec 1, 2020 · 3 comments
Assignees
Labels
enhancement Request for new feature and/or capability stale The issue is stale. It will be closed within 7 days unless there are further conversation

Comments

@clarkzinzow
Copy link
Contributor

clarkzinzow commented Dec 1, 2020

We need to add unit tests for the ownership-based object directory. Note that the (current) GCS-based object directory doesn't have unit tests, and we could achieve testing coverage parity with the current object directory by giving an ownership-based object directory instance to the object manager in the object manager tests (and the stress tests).

Initial OBOD implementation was added in #9735.

@clarkzinzow clarkzinzow added enhancement Request for new feature and/or capability triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Dec 1, 2020
@ericl ericl removed the triage Needs triage (eg: priority, bug/not-bug, and owning component) label Dec 8, 2020
@clarkzinzow clarkzinzow self-assigned this Feb 5, 2021
@clarkzinzow clarkzinzow changed the title [Core] Owernership-based Object Directory - add unit tests [Core] Owernership-based Object Directory - remove GCS-based object directory, add OBOD unit tests May 3, 2021
@clarkzinzow
Copy link
Contributor Author

The scope of this has been increased to include removing the GCS-based object directory.

@stale
Copy link

stale bot commented Aug 31, 2021

Hi, I'm a bot from the Ray team :)

To help human contributors to focus on more relevant issues, I will automatically add the stale label to issues that have had no activity for more than 4 months.

If there is no further activity in the 14 days, the issue will be closed!

  • If you'd like to keep the issue open, just leave any comment, and the stale label will be removed!
  • If you'd like to get more attention to the issue, please tag one of Ray's contributors.

You can always ask for help on our discussion forum or Ray's public slack channel.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Aug 31, 2021
@stale
Copy link

stale bot commented Sep 14, 2021

Hi again! The issue will be closed because there has been no more activity in the 14 days since the last message.

Please feel free to reopen or open a new issue if you'd still like it to be addressed.

Again, you can always ask for help on our discussion forum or Ray's public slack channel.

Thanks again for opening the issue!

@stale stale bot closed this as completed Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for new feature and/or capability stale The issue is stale. It will be closed within 7 days unless there are further conversation
Projects
None yet
Development

No branches or pull requests

2 participants