Skip to content

Commit ebf0cb3

Browse files
committed
update kai-scheduler to fit batchscheduler interface
Signed-off-by: You-Cheng Lin (Owen) <[email protected]>
1 parent 6c0d860 commit ebf0cb3

File tree

1 file changed

+11
-1
lines changed

1 file changed

+11
-1
lines changed

ray-operator/controllers/ray/batchscheduler/kai-scheduler/kai_scheduler.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ package kaischeduler
99

1010
import (
1111
"context"
12+
"fmt"
1213

1314
"github.com/go-logr/logr"
1415
corev1 "k8s.io/api/core/v1"
@@ -36,7 +37,13 @@ func GetPluginName() string { return "kai-scheduler" }
3637

3738
func (k *KaiScheduler) Name() string { return GetPluginName() }
3839

39-
func (k *KaiScheduler) DoBatchSchedulingOnSubmission(_ context.Context, _ *rayv1.RayCluster) error {
40+
func (k *KaiScheduler) DoBatchSchedulingOnSubmission(_ context.Context, object client.Object) error {
41+
_, ok := object.(*rayv1.RayCluster)
42+
if !ok {
43+
return fmt.Errorf("currently only RayCluster is supported, got %T", object)
44+
}
45+
// yunikorn doesn't require any resources to be created upfront
46+
// this is a no-opt for this implementation
4047
return nil
4148
}
4249

@@ -56,6 +63,9 @@ func (k *KaiScheduler) AddMetadataToPod(_ context.Context, app *rayv1.RayCluster
5663
pod.Labels[QueueLabelName] = queue
5764
}
5865

66+
func (k *KaiScheduler) AddMetadataToChildResource(_ context.Context, _ client.Object, _ string, _ client.Object) {
67+
}
68+
5969
func (kf *KaiSchedulerFactory) New(_ context.Context, _ *rest.Config, _ client.Client) (schedulerinterface.BatchScheduler, error) {
6070
return &KaiScheduler{
6171
log: logf.Log.WithName("kai-scheduler"),

0 commit comments

Comments
 (0)