Skip to content

Conversation

@ravisaxena23
Copy link
Owner

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

wilsonge and others added 30 commits November 12, 2019 11:11
Joomla! 3.9.12 Release
Make sure that we correctly refer to LICENSE.txt and GPL 2 or later
* [4.0] Fixing useless blank img tag in admin menu

* else not necessary here for $iconImage
* messages badge

* messages badge

* messages badge

* setState

* unread

* unread is 0
* [4.0] Language strings are coupled to template

The string TPL_ATUM_TOGGLE_SIDEBAR should not be tied to the template. This PR renames the string to JTOGGLE_SIDEBAR_MENU and moves it to the generic language file

* .

* order
* [4.0] Correcting wrong debug lang untranslated strings

* using correct labels
* [4.0] Correcting accessibility in sidebar menu

* Taking off 'New" when not necessary

* oops
* [4.0] Correcting mod_submenu markup

* moving code after conditional and more

* taking off redundant conditional
SharkyKZ and others added 29 commits January 15, 2020 12:38
This should be a button and not a link.
The language strings for the popup titles were not being passed through jtext
I have no idea why but this cog icon button was given a class of btn-link. This meant that there was no visible indicator of focus. Removal of that class now means that you can visibly tab around the dashboard and see where you are
Alternative to #27489
This requires no template overrides at all
Merge latest J4 in page builder
@ravisaxena23 ravisaxena23 merged commit 31d3cbc into ravisaxena23:development Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.