Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add method to add a trimming curve to an already created Grid #48

Open
henrij22 opened this issue Nov 23, 2023 · 0 comments · May be fixed by #51
Open

Feature: add method to add a trimming curve to an already created Grid #48

henrij22 opened this issue Nov 23, 2023 · 0 comments · May be fixed by #51
Assignees
Labels
enhancement New feature or request

Comments

@henrij22
Copy link
Collaborator

henrij22 commented Nov 23, 2023

It should be possible to add (additional) trimming curves to an already existing grid, weather this grid was created manually by hand or with the IbraReader.

This feature should also check if the added trimming curves are overlapping with already existing ones. At least it should be looked into the behaviour that arises from that.

To implement this, one has to think about if the curve is to be defined in the physical or the parameter space. A curve in the physical space has to be transferred firstly to the parameter space of the surface. Is a total reparametrisation needed or is it enough to transform the control points.

@henrij22 henrij22 added the enhancement New feature or request label Nov 23, 2023
@henrij22 henrij22 self-assigned this Nov 23, 2023
@henrij22 henrij22 linked a pull request Jul 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant