Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render svgs with different attributes in dark and light mode #506

Closed
ad-chaos opened this issue Mar 11, 2024 · 2 comments
Closed

Render svgs with different attributes in dark and light mode #506

ad-chaos opened this issue Mar 11, 2024 · 2 comments

Comments

@ad-chaos
Copy link

Its a little hard to read at the moment:

Screenshot 2024-03-11 at 9 31 08 PM

I've made a PR to svgbob-wasm (used by a dependency of remark-svgbob) which adds the ability to specify some settings to svgbob before rendering.

@ad-chaos ad-chaos changed the title Render svg's with different attributes in dark and light Render svgs with different attributes in dark and light Mar 11, 2024
@ad-chaos ad-chaos changed the title Render svgs with different attributes in dark and light Render svgs with different attributes in dark and light mode Mar 11, 2024
@kdheepak
Copy link
Contributor

Thank you for making a PR to svgbob-wasm! I didn't test on dark mode, my bad. If there's any change that I can make to remark-svgbob let me know!

https://github.com/kdheepak/remark-svgbob

@ad-chaos
Copy link
Author

ah, seems like its fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants