Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yamllint does not work on Windows #31

Closed
vgolynets opened this issue May 13, 2022 · 1 comment
Closed

yamllint does not work on Windows #31

vgolynets opened this issue May 13, 2022 · 1 comment

Comments

@vgolynets
Copy link

On Windows yamllint does not work since v1.3.0. Issue is that globbySync does not understand patterns with back slashes, see related issue sindresorhus/globby#130.

Even if you run yamllint with forward slashes e.g. yamllint some/path/to/my.yaml, then call of resolve(process.cwd(), pattern) breaks it because converts path to Windows style i.e. some\path\to\my.yaml.

Simple solution is to use something like resolve(process.cwd(), pattern).replace(/\\/g, '/').

@rasshofer
Copy link
Owner

rasshofer commented May 13, 2022

Oops, sorry about that. daa4899 fixes the issue and I extended the CI pipeline to also run the tests in Windows and macOS to catch such issues in the future. The fixed version has been released as v1.7.0 a few seconds ago.

Thanks for the detailed report, much appreciated! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants