Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated oauth2client in favour of google-auth #9989

Closed
2 tasks
joejuzl opened this issue Oct 27, 2021 · 1 comment
Closed
2 tasks

Replace deprecated oauth2client in favour of google-auth #9989

joejuzl opened this issue Oct 27, 2021 · 1 comment
Assignees
@tayfun
Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@joejuzl
Copy link
Contributor

joejuzl commented Oct 27, 2021

Description

oauth2client has been deprecated.
It is now causing an error when pyparsing>=3.0.0.

module 'pyparsing' has no attribute 'downcaseTokens'

See sentry.

The recommended library to change to is google-auth.

We currently only use oauth2client in hangouts.py (to verify the bot token).

Definition of Done:

  • We no longer use oauth2client in Rasa OSS.
  • We maintain current functionality for the hangouts channel.
@joejuzl joejuzl added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/channels 📞 Issues focused around rasas input and output channels labels Oct 27, 2021
@joejuzl joejuzl mentioned this issue Oct 29, 2021
Closed
@TyDunn TyDunn added the effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Oct 29, 2021
@tayfun
Copy link
Contributor

tayfun commented Oct 29, 2021

Hangouts is deprecated in favour of Google Chat (see https://blog.google/products/workspace/latest-google-hangouts-and-upgrade-google-chat/ ), so might be a good idea to check how much Hangouts channel is being used and maybe even drop support if not utilized much.

@tayfun tayfun mentioned this issue Nov 3, 2021
Merged
4 tasks
@m-vdb m-vdb closed this as completed Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tayfun tayfun

Labels
area:rasa-oss/channels 📞 Issues focused around rasas input and output channels area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/2 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tayfun @joejuzl @m-vdb @TyDunn