Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pyjwt version pin by updating sanic-jwt #9858

Closed
3 tasks
usc-m opened this issue Oct 13, 2021 · 0 comments · Fixed by #9937
Closed
3 tasks

Fix pyjwt version pin by updating sanic-jwt #9858

usc-m opened this issue Oct 13, 2021 · 0 comments · Fixed by #9937
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework

Comments

@usc-m
Copy link
Contributor

usc-m commented Oct 13, 2021 •
edited
Loading

On the 2.8.x branch we've had to pin pyjwt to 2.1.0 to fix a dependency issue caused by sanic-jwt 1.5.0 which breaks on 2.2.0 but does not specify an acceptable version range. This is fixed with sanic-jwt 1.7.0 but may cause breakage (especially with Rasa X), which will need investigated.

Definition of Done

  • Investigate breakage caused if sanic-jwt is updated
  • Update package and remove pyjwt pin
  • Investigate if this needs to be done for 3.X
@usc-m usc-m added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Oct 13, 2021
@wochinge wochinge mentioned this issue Oct 15, 2021
Closed
9 tasks
@usc-m usc-m mentioned this issue Oct 20, 2021
Merged
1 task
@usc-m usc-m linked a pull request Oct 20, 2021 that will close this issue
Update sanic-jwt version pin to match Rasa X #9937
Merged
1 task
@usc-m usc-m closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update sanic-jwt version pin to match Rasa X RasaHQ/rasa
1 participant
@usc-m