Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to OR slot values - Implementation #8933

Closed
5 tasks
joejuzl opened this issue Jun 22, 2021 · 0 comments · Fixed by #9317
Closed
5 tasks

Make it possible to OR slot values - Implementation #8933

joejuzl opened this issue Jun 22, 2021 · 0 comments · Fixed by #9317
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@joejuzl
Copy link
Contributor

joejuzl commented Jun 22, 2021

Description of Problem:
Background: #7715
Proposed Solution: https://www.notion.so/rasa/Make-it-possible-to-OR-slot-values-4abdf1b6632c4bb2881d2057b58ca335

Summary:
We want to be able to use or for slot_was_set steps in stories.
It currently only works for intent steps.

Todo:

  • updating the story schema rasa/shared/utils/schemas/stories.yml
  • updating YAMLStoryReader
    • _parse_or_statement
  • updating StoryStepBuilder
    • adding a slot_was_set equivalent to add_user_messages
  • make sure rasa.shared.core.training_data.visualization is updated for Rasa X story visualisation

Example Story:

- story: tell name bob or joe
  steps:
  - intent: greet
  - action: utter_greet
  - intent: tell_name
  - or:
    - slot_was_set:
        - name: joe
    - slot_was_set:
        - name: bob
  - action: utter_generic_hi

Definition of Done:

  • or functionality added for slot_was_set events
  • Rasa X visualisation compatibility
  • Tests are added
  • Feature described the docs
  • Feature mentioned in the changelog
@joejuzl joejuzl added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) labels Jun 22, 2021
@joejuzl joejuzl added this to the 3.0 Rasa Open Source milestone Jun 22, 2021
@wochinge wochinge added the effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/training-data Issues focused around Rasa training data (stories, NLU, domain, etc.) effort:atom-squad/4 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants