Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0 Deprecation Warning: Remove deprecated Message method #8883

Closed
4 tasks done
ancalita opened this issue Jun 15, 2021 · 3 comments · Fixed by #9088
Closed
4 tasks done

3.0 Deprecation Warning: Remove deprecated Message method #8883

ancalita opened this issue Jun 15, 2021 · 3 comments · Fixed by #9088
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework maintenance:rasa-3.0/deprecation

Comments

@ancalita
Copy link
Member

ancalita commented Jun 15, 2021

Background
This warning was found in:

  • rasa.shared.nlu.training_data.message.py:L188
"""`get_combined_intent_response_key` is deprecated and ""
""will be removed in Rasa 3.0.0. ""
""Please use `get_full_intent` instead."""

Definition of Done

  • resolve warning in 3.0 version
  • Removed the method from the codebase.
  • Added a changelog entry for 3.0 saying we've removed the previously deprecated method.
  • Removed the references in the docs
@ancalita ancalita added the area:rasa-oss 🎡 Anything related to the open source Rasa framework label Jun 15, 2021
@TyDunn TyDunn added this to the 3.0 Rasa Open Source milestone Jun 15, 2021
@samsucik
Copy link
Contributor

samsucik commented Jul 9, 2021

Can this be done right now? For 3.0 stuff, do we simply target main?

In any case, since the deprecated method doesn't appear anywhere in our Rasa Open Source tests or docs, the definition of done can be, I think, as simple as:

  1. Removed the method from the codebase.
  2. Added a changelog entry for 3.0 saying we've removed the previously deprecated method.

@ancalita
Copy link
Member Author

ancalita commented Jul 9, 2021

Can this be done right now? For 3.0 stuff, do we simply target main?

I think all deprecations will be part of the prep work that can be done after the 2.8. release, targeting main - @m-vdb correct me if I'm wrong about the timeline?

@m-vdb
Copy link
Collaborator

m-vdb commented Jul 9, 2021

yep 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework maintenance:rasa-3.0/deprecation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants