Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dockerfile] Create rasa user and group #8802

Merged
merged 3 commits into from
Jun 3, 2021
Merged

[Dockerfile] Create rasa user and group #8802

merged 3 commits into from
Jun 3, 2021

Conversation

tczekajlo
Copy link
Contributor

Proposed changes:

  • Create rasa user and group
  • Set the HOME environment variable to /app

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tczekajlo tczekajlo self-assigned this Jun 3, 2021
erohmensing
erohmensing approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@erohmensing erohmensing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👀 can we also add a changelog entry so that anyone who manually sets the HOME env var knows it has changed?

@tczekajlo tczekajlo merged commit b472e6f into main Jun 3, 2021
@tczekajlo tczekajlo deleted the add_user_group_docker branch June 3, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erohmensing erohmensing erohmensing approved these changes

Assignees

@tczekajlo tczekajlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tczekajlo @erohmensing