Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

correctly validate whether response selector responses from stories are valid if responses are found in the domain #8631

Merged
merged 4 commits into from
May 17, 2021
Merged

correctly validate whether response selector responses from stories are valid if responses are found in the domain #8631

merged 4 commits into from
May 17, 2021

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented May 7, 2021 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing requested a review from ancalita May 7, 2021 14:06
ancalita
ancalita reviewed May 11, 2021
View reviewed changes
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great! One tiny thing though - could you please add the context behind this fix and/or the GH issue link in the PR description, it's not very clear until you read the changelog.

@erohmensing
Copy link
Contributor Author

Oh whoops! I didn't realize i forgot to update it, thanks!

@erohmensing erohmensing requested a review from ancalita May 17, 2021 12:18
@erohmensing erohmensing linked an issue May 17, 2021 that may be closed by this pull request
rasa data validate doesn't correctly identify response selector responses in domain #8633
Closed
@erohmensing erohmensing merged commit 6a78bdc into 2.6.x May 17, 2021
@erohmensing erohmensing deleted the response-selector-validate branch May 17, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancalita ancalita ancalita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rasa data validate doesn't correctly identify response selector responses in domain
2 participants
@erohmensing @ancalita