Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update links to Sanic docs in our documentation #8080

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Update links to Sanic docs in our documentation #8080

merged 2 commits into from
Mar 2, 2021

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Mar 2, 2021 •
edited
Loading

Proposed changes:
Sanic recently updated links so the old ones now return 404 which makes cd docs && yarn mdx-lint command fail.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

wochinge
wochinge approved these changes Mar 2, 2021
View reviewed changes
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 This probably also needs to go in 2.3.x, doesn't it?

@alwx alwx changed the base branch from main to 2.3.x March 2, 2021 08:18
@alwx alwx requested a review from a team March 2, 2021 08:18
@alwx alwx requested a review from a team as a code owner March 2, 2021 08:18
@alwx alwx removed request for a team and erohmensing March 2, 2021 08:19
@alwx alwx enabled auto-merge (rebase) March 2, 2021 08:20
@alwx alwx merged commit 3d3f172 into 2.3.x Mar 2, 2021
@alwx alwx deleted the sanic-links branch March 2, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wochinge wochinge wochinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alwx @wochinge