Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove experimental label for rasa data validate stories #8024

Closed
3 tasks done
TyDunn opened this issue Feb 23, 2021 · 4 comments
Closed
3 tasks done

Remove experimental label for rasa data validate stories #8024

TyDunn opened this issue Feb 23, 2021 · 4 comments
Assignees
@aeshky @koernerfelicia
Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@TyDunn
Copy link
Contributor

TyDunn commented Feb 23, 2021 •
edited by aeshky
Loading

@JEM-Mosig and I agree that rasa data validate stories is a core part of test step of CDD, where you make sure that there are no conflicts in your stories before automated tests in a CI pipeline, and we should remove the experimental feature designation in the Rasa Open Source docs

https://rasa.com/docs/rasa/command-line-interface#rasa-data-validate

Definition of done

  • Remove experimental warning in docs
  • Remove the warning in the code
  • Update the experimental feature table in Notion
@TyDunn TyDunn added type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework area:rasa-oss/cli Issues focused on the rasa command-line-interface labels Feb 23, 2021
@pranavdurai10
Copy link
Contributor

@TyDunn @JEM-Mosig is this still open for contribution? If so, can I take over?

@TyDunn
Copy link
Contributor Author

TyDunn commented Mar 14, 2021

@pranavdurai10 Yes 👍

@alopez alopez assigned alopez, aeshky and koernerfelicia and unassigned alopez Jul 23, 2021
@alopez
Copy link
Contributor

alopez commented Jul 23, 2021

assignee: @aeshky
reviewer: @koernerfelicia

@aeshky aeshky mentioned this issue Jul 24, 2021
Closed
4 tasks
@aeshky
Copy link
Contributor

aeshky commented Jul 24, 2021 •
edited
Loading

Working branch: remove_exp_label.
Note: I could not find a warning in the code associated with rasa data validate stories.
Notion page updated: here.
Pull request:
#9194 this PR got too messy when I changed the target branch.
I created a new PR here: #9237

This was referenced Jul 26, 2021
Closed
Merged
@aeshky aeshky closed this as completed Jul 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aeshky aeshky

@koernerfelicia koernerfelicia

Labels
area:rasa-oss/cli Issues focused on the rasa command-line-interface area:rasa-oss 🎡 Anything related to the open source Rasa framework type:docs 📖 Improvements to the documenation. Adding missing pieces or improving existing ones. type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alopez @aeshky @TyDunn @pranavdurai10 @koernerfelicia