Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka group_id #8019

Merged
merged 8 commits into from
Feb 23, 2021
Merged

Kafka group_id #8019

merged 8 commits into from
Feb 23, 2021

Conversation

indam23
Copy link
Contributor

@indam23 indam23 commented Feb 22, 2021 •
edited
Loading

Proposed changes:

  • Add back the group_id parameter to the KafkaEventBroker instead of **kwargs to allow using the same config for producer and consumer
  • Raise a warning when group_id is provided since it is not actually used by the producer

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@indam23 indam23 changed the base branch from main to 1.10.x February 22, 2021 22:15
@indam23 indam23 changed the title Kafka kwargs Kafka group_id Feb 22, 2021
@indam23 indam23 merged commit e73181a into 1.10.x Feb 23, 2021
@indam23 indam23 deleted the kafka_kwargs branch February 23, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@federicotdn federicotdn federicotdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indam23 @federicotdn