Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finetuning does not work when passing a model with the --finetune argument. #7829

Closed
joejuzl opened this issue Jan 27, 2021 · 0 comments · Fixed by #7902
Closed

Finetuning does not work when passing a model with the --finetune argument. #7829

joejuzl opened this issue Jan 27, 2021 · 0 comments · Fixed by #7902
Assignees
@Imod7
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@joejuzl
Copy link
Contributor

joejuzl commented Jan 27, 2021

Rasa version: 2.2.7

Issue:
When we pass a model path using --finetune we parse it incorrectly and return None. This means it won't finetune anything.

Command or request that led to error:

rasa train nlu --finetune models/nlu-20210127-140930.tar.gz

The problem is we don't correct handle an else in rasa/cli/train.py._model_for_finetuning.
@joejuzl joejuzl added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework priority:high effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. labels Jan 27, 2021
@Imod7 Imod7 linked a pull request Feb 8, 2021 that will close this issue
Finetuning (--finetune) with a specific model as an argument #7902
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Imod7 Imod7

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework effort:atom-squad/1 Label which is used by the Rasa Atom squad to do internal estimation of task sizes. type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Finetuning (--finetune) with a specific model as an argument RasaHQ/rasa
2 participants
@joejuzl @Imod7