hide only rule dialogue turns #7701

Ghostvv · 2021-01-08T13:09:23Z

Proposed changes:

closes Unfeaturize rule snippets for inference through TED #7226

originally I had 2 ideas: operate on states or use forgetting functionality in tracker.applied_events through specialized events. In the end I used the mix of these approaches.

Status (please check what you already did):

added some tests for the functionality
updated the documentation
updated the changelog (please check changelog for instructions)
reformat files using black (please check Readme for instructions)

…_rules

docs/docs/rules.mdx

changelog/7701.improvement.md

docs/docs/rules.mdx

Co-authored-by: Ella Rohm-Ensing <[email protected]>

Ghostvv · 2021-01-11T15:31:03Z

@wochinge could you please take a look if we can remove forgetting of TwoStageFallback rules

…_ml_policy

dakshvar22

Amazing job on this§1 💯 Just a couple of minor comments from my side.

rasa/core/policies/ted_policy.py

rasa/core/policies/rule_policy.py

rasa/shared/core/domain.py

tests/core/policies/test_rule_policy.py

wochinge

I need a bit more time to digest this so here is my input on this so far:

If users turn of _check_for_contradictions then this wouldn't work only longer, correct?
Wouldn't it be better to warn the user that they should add a story so that the ML policies can learn to perform the transition after a rule application instead of completely blanking out the rule?
Could we also to this without the additional event and simply remove all events before an ActionExecuted with policy=="RulePolicy" until the previous action?

rasa/core/featurizers/tracker_featurizers.py

rasa/core/policies/policy.py

rasa/core/policies/ted_policy.py

rasa/core/policies/rule_policy.py

Ghostvv · 2021-01-20T18:52:53Z

Wouldn't it be better to warn the user that they should add a story so that the ML policies can learn to perform the transition after a rule application instead of completely blanking out the rule?

no, because you'd need to add combinatorial number of rules into stories, which is unnecessary if you can hide rules

Could we also to this without the additional event and simply remove all events before an ActionExecuted with policy=="RulePolicy" until the previous action?

no, because not all rules should be ignored, only the ones that are not present in the stories, also not all slot sets should be ignored

Co-authored-by: Tobias Wochinger <[email protected]>

wochinge · 2021-03-15T08:09:58Z

But the domain currently contains all the shared information already, no?

Actually, they can be different after each retrain

What do you mean? You mean in case you add another story?

Ghostvv · 2021-03-15T09:20:41Z

What do you mean? You mean in case you add another story?

yes

Ghostvv · 2021-03-15T09:21:24Z

also, updating domain retrospectively after training doesn't feel right

Ghostvv · 2021-03-18T15:46:05Z

@wochinge could you give it a review? is it ready to merge?

wochinge · 2021-03-18T16:26:46Z

rasa/core/policies/policy.py


    @property
    def featurizer(self):
        """Returns the policy's featurizer."""
        return self.__featurizer

+    def set_rule_only_data(self, rule_only_data: Dict[Text, Any]) -> None:


how about using something which generalizes better?

def set_shared_policy_state(**kwargs: Any) -> None

Advantages:

no deprecation is required if we want to pass more information / different information

users can use this for their own policies (e.g. setting some shared state originating from their policies)

users wouldn't be able to use it, since ensemble will only pass rule_only_data

renamed the method

rasa/core/policies/policy.py

rasa/shared/core/domain.py

rasa/shared/core/generator.py

rasa/shared/core/trackers.py

rasa/core/policies/rule_policy.py

Co-authored-by: Tobias Wochinger <[email protected]>

wochinge

👍🏻

Ghostvv · 2021-03-22T14:12:42Z

@wochinge do you have an idea why test docs fail? I tried restarting the docs test several times

wochinge · 2021-03-22T14:15:14Z

due to #8272

hide only rule dialogue turns

29901e3

Ghostvv requested review from joejuzl, wochinge, dakshvar22 and a team January 8, 2021 13:09

Ghostvv and others added 8 commits January 8, 2021 14:22

add missing docstrings

d957f5d

fix docstrings

c7fed26

Merge branch 'master' into hide_rules

02e35f4

fix hiding rules

ff5014a

Merge branch 'hide_rules' of https://github.com/RasaHQ/rasa into hide…

52c5b31

…_rules

add tests

ab64782

add changelog

e55933e

add docs

f7d083b

erohmensing reviewed Jan 11, 2021

View reviewed changes

docs/docs/rules.mdx Outdated Show resolved Hide resolved

changelog/7701.improvement.md Outdated Show resolved Hide resolved

docs/docs/rules.mdx Outdated Show resolved Hide resolved

Ghostvv and others added 3 commits January 11, 2021 16:28

Update docs/docs/rules.mdx

ee525c6

Co-authored-by: Ella Rohm-Ensing <[email protected]>

Update changelog/7701.improvement.md

bcca577

Co-authored-by: Ella Rohm-Ensing <[email protected]>

Update docs/docs/rules.mdx

cba4f69

Co-authored-by: Ella Rohm-Ensing <[email protected]>

create featurize for prediction helpers to automatically set for_only…

75516ce

…_ml_policy

dakshvar22 previously approved these changes Jan 11, 2021

View reviewed changes

rasa/core/policies/ted_policy.py Outdated Show resolved Hide resolved

rasa/core/policies/rule_policy.py Outdated Show resolved Hide resolved

rasa/shared/core/domain.py Outdated Show resolved Hide resolved

tests/core/policies/test_rule_policy.py Show resolved Hide resolved

Ghostvv and others added 4 commits January 12, 2021 13:10

additionaly check states in the test

fa77daa

Merge branch 'master' into hide_rules

2d14b24

add a test for a rule without action listen in the end

fc92ab2

Merge branch 'master' into hide_rules

a0c9fa9

Ghostvv added the tools:clear-poetry-cache-unit-tests Clear poetry cache for the unit tests label Jan 20, 2021

Merge branch 'master' into hide_rules

4a8e6d9

wochinge reviewed Jan 20, 2021

View reviewed changes

Ghostvv and others added 2 commits January 20, 2021 19:53

Update rasa/core/policies/policy.py

7bc11de

Co-authored-by: Tobias Wochinger <[email protected]>

Update rasa/core/policies/ted_policy.py

0d43cd4

Co-authored-by: Tobias Wochinger <[email protected]>

Ghostvv and others added 3 commits March 11, 2021 12:45

add docstring

d981e27

Merge branch 'main' into hide_rules

19b7305

merge main

703ff3c

Ghostvv added 2 commits March 15, 2021 11:30

merge main

962b411

fix omit_unset_slots merge

34d48dd

Ghostvv requested review from wochinge and removed request for joejuzl March 15, 2021 12:50

Merge branch 'main' into hide_rules

fd3af73

wochinge reviewed Mar 18, 2021

View reviewed changes

Ghostvv and others added 2 commits March 18, 2021 17:52

rename to shared states

8a298ec

Merge branch 'main' into hide_rules

68660b9

wochinge reviewed Mar 19, 2021

View reviewed changes

Ghostvv and others added 5 commits March 19, 2021 10:23

Update rasa/shared/core/domain.py

5d5f83d

Co-authored-by: Tobias Wochinger <[email protected]>

Update rasa/shared/core/trackers.py

e2b7342

Co-authored-by: Tobias Wochinger <[email protected]>

Update rasa/core/policies/rule_policy.py

fb039cd

Co-authored-by: Tobias Wochinger <[email protected]>

Update rasa/shared/core/generator.py

c1ed6ba

Co-authored-by: Tobias Wochinger <[email protected]>

update changelog

fe2aab6

Ghostvv removed the tools:clear-poetry-cache-unit-tests Clear poetry cache for the unit tests label Mar 19, 2021

wochinge approved these changes Mar 22, 2021

View reviewed changes

Merge branch 'main' into hide_rules

031c8a4

Ghostvv enabled auto-merge (squash) March 22, 2021 09:06

Merge branch 'main' into hide_rules

67502b6

Ghostvv merged commit 8258c55 into main Mar 22, 2021

Ghostvv deleted the hide_rules branch March 22, 2021 14:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hide only rule dialogue turns #7701

hide only rule dialogue turns #7701

Ghostvv commented Jan 8, 2021 •

edited

Loading

Ghostvv commented Jan 11, 2021

dakshvar22 left a comment

wochinge left a comment

Ghostvv commented Jan 20, 2021

wochinge commented Mar 15, 2021

Ghostvv commented Mar 15, 2021

Ghostvv commented Mar 15, 2021

Ghostvv commented Mar 18, 2021

wochinge Mar 18, 2021

Ghostvv Mar 18, 2021

Ghostvv Mar 18, 2021

wochinge left a comment

Ghostvv commented Mar 22, 2021 •

edited

Loading

wochinge commented Mar 22, 2021

hide only rule dialogue turns #7701

hide only rule dialogue turns #7701

Conversation

Ghostvv commented Jan 8, 2021 • edited Loading

Ghostvv commented Jan 11, 2021

dakshvar22 left a comment

Choose a reason for hiding this comment

wochinge left a comment

Choose a reason for hiding this comment

Ghostvv commented Jan 20, 2021

wochinge commented Mar 15, 2021

Ghostvv commented Mar 15, 2021

Ghostvv commented Mar 15, 2021

Ghostvv commented Mar 18, 2021

wochinge Mar 18, 2021

Choose a reason for hiding this comment

Ghostvv Mar 18, 2021

Choose a reason for hiding this comment

Ghostvv Mar 18, 2021

Choose a reason for hiding this comment

wochinge left a comment

Choose a reason for hiding this comment

Ghostvv commented Mar 22, 2021 • edited Loading

wochinge commented Mar 22, 2021

Ghostvv commented Jan 8, 2021 •

edited

Loading

Ghostvv commented Mar 22, 2021 •

edited

Loading