Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multidict dependency #7426

Merged
merged 2 commits into from
Dec 1, 2020
Merged

remove multidict dependency #7426

merged 2 commits into from
Dec 1, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Dec 1, 2020

Proposed changes:

  • remove multidict dependency which is not a direct dependency of Rasa Open Source but just a dependency of our dependencies
  • fix
     sanic 20.9.1 has requirement multidict==5.0.0, but you'll have multidict 4.6.0 which is incompatible.
    

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge requested a review from alwx December 1, 2020 14:01
@wochinge wochinge merged commit 5539966 into 2.1.x Dec 1, 2020
@wochinge wochinge deleted the remove-multidict-dependency branch December 1, 2020 18:03
@asmaier
Copy link

asmaier commented May 19, 2021

Unfortunately this problem exists again in Rasa 2.6.2, see https://github.com/RasaHQ/rasa/blob/2.6.2/pyproject.toml#L100

@wochinge
Copy link
Contributor Author

created a PR for it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants