Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply is_url fix for 2.1.x #7345

Merged
merged 6 commits into from
Nov 27, 2020
Merged

Apply is_url fix for 2.1.x #7345

merged 6 commits into from
Nov 27, 2020

Conversation

federicotdn
Copy link
Contributor

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@federicotdn federicotdn merged commit 19ff956 into 2.1.x Nov 27, 2020
@federicotdn federicotdn deleted the fix-is-url-2.1.x branch November 27, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants