Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all_retrieval_intents key in response selector output #7200

Merged
merged 5 commits into from
Nov 9, 2020
Merged

Fix all_retrieval_intents key in response selector output #7200

merged 5 commits into from
Nov 9, 2020

Conversation

dakshvar22
Copy link
Contributor

@dakshvar22 dakshvar22 commented Nov 6, 2020 •
edited
Loading

Proposed changes:

  • Earlier the list of retrieval intents was being retrieved after filtering the data for intents inside preprocess_train_data. This lead to some retrieval intents being omitted from being present in the all_retrieval_intent key of the response selector output. Now this is fixed.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

dakshvar22
dakshvar22 commented Nov 6, 2020
View reviewed changes
changelog/7200.bugfix.md Outdated Show resolved Hide resolved
tabergma
tabergma approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@rasabot rasabot merged commit 5fd4f71 into 2.0.x Nov 9, 2020
@rasabot rasabot deleted the fix_all_retrieval_intents branch November 9, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tabergma tabergma tabergma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dakshvar22 @tabergma @rasabot