Restrict acceptable values for model_url parameter of ConveRTTokenizer #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
dakshvar22
commented
Oct 28, 2020
|
@dakshvar22 Seems the remaining docstring issues are valid. |
|
@wochinge Just pushed fixes for them. |
wochinge
reviewed
Oct 29, 2020
| model_directory: Directory to investigate | ||
| """ | ||
| files_to_check = [ | ||
| os.path.join(model_directory, "saved_model.pb"), |
There was a problem hiding this comment.
optional: let's use the pathlib to concatenate /deal with the paths.
wochinge
approved these changes
Oct 29, 2020
dakshvar22
commented
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)