Fixes for story/rules reading and writing for both formats #7033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
reviewed
Oct 19, 2020
rasa/shared/core/training_data/story_reader/yaml_story_reader.py
Outdated
Show resolved
Hide resolved
wochinge
approved these changes
Oct 20, 2020
tests/shared/core/training_data/story_reader/test_yaml_story_reader.py
Outdated
Show resolved
Hide resolved
rasa/shared/core/training_data/story_reader/yaml_story_reader.py
Outdated
Show resolved
Hide resolved
|
Can you please update the PR description to match the changes? 🙌 |
|
commenting to receive notifications for when this is merged 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
_is_used_for_training=Falsein YAMLStoryReader, so that we can represent OR statements as lists of events, instead of having to split off into multiple stories.Fixes https://github.com/RasaHQ/rasa-x/issues/3735 and https://github.com/RasaHQ/rasa-x/issues/3733.
Status (please check what you already did):
black(please check Readme for instructions)